GSA / px-benefit-finder

1 stars 1 forks source link

QA | Design v0.8.0 beta.1 #1909

Open EnriqueOrt-GSA opened 3 weeks ago

EnriqueOrt-GSA commented 3 weeks ago

Domain

design

Related Issue(s)

Centering select an option modal text & buttons https://github.com/GSA/px-benefit-finder/issues/1891

Description

Content QA - Please review and confirm the tickets listed above - you should review and work on Main

Due date: 11/04/2024 or as soon as available

fongcindy commented 3 weeks ago

@ErnestoFernandezAlvarez friendly reminder that this QA is due Monday 11/4, please flag any issues you see in this ticket here! 😊 Any reason why this is blocked?

@EnriqueOrt-GSA for viz

ErnestoFernandezAlvarez commented 2 weeks ago

Hello @EnriqueOrt-GSA just want to confirm: Isthis is happening in the actual usa.gov environment: I will go through the user flow and see what happens with the modal.

ErnestoFernandezAlvarez commented 2 weeks ago

There seems to be a bug. Here is a screenshot taken today 11/4:

Screenshot 2024-11-04 at 11 07 41 AM
ErnestoFernandezAlvarez commented 2 weeks ago

@EnriqueOrt-GSA This is the correct modal layout:

Screenshot 2024-11-04 at 11 09 19 AM

Also please see the figma file: https://www.figma.com/design/3qui91uX0iE4YMNrnx4gzK/ReDesign-Benefit-Finder?node-id=1033-1171&t=bSgf6sNffcds7YiQ-1

ErnestoFernandezAlvarez commented 2 weeks ago

@EnriqueOrt-GSA @gscottqueen Do you need any further input in this ticket? Could I close it as 'Done'? Thank you

scottqueen-bixal commented 1 week ago

This passed technical review here https://github.com/GSA/px-benefit-finder/pull/1920, and can be found here -> https://bf-cms-dev.bxdev.net/benefit-finder/death