GSA / px-benefit-finder

1 stars 0 forks source link

Date and some eligibility criteria not working for some benefits (Covid scenario) #67

Closed diegocob closed 10 months ago

diegocob commented 10 months ago

Description

When running the Covid persona scenario: https://benefit-finder-waf-main.app.cloud.gov/benefit-finder/death?applicant_date_of_birth=%7B%22month%22%3A%223%22%2C%22day%22%3A%2205%22%2C%22year%22%3A%221960%22%7D&applicant_relationship_to_the_deceased=Spouse&applicant_marital_status=Widowed&applicant_citizen_status=Yes&applicant_care_for_child=Yes&applicant_paid_funeral_expenses=Yes&deceased_date_of_death=%7B%22month%22%3A%221%22%2C%22day%22%3A%2203%22%2C%22year%22%3A%222022%22%7D&deceased_death_location_is_US=Yes&deceased_paid_into_SS=Yes&deceased_public_safety_officer=No&deceased_miner=No&deceased_american_indian=No&deceased_died_of_COVID=Yes&deceased_served_in_active_military=No&shared=true'

The date and other eligibility criteria for these benefits needs fixing:

This is the link to the scenario in Spanish: https://benefit-finder-waf-main.app.cloud.gov/es/benefit-finder/death?es_applicant_date_of_birth=%7B%22month%22%3A%223%22%2C%22day%22%3A%225%22%2C%22year%22%3A%221960%22%7D&es_applicant_relationship_to_the_deceased=C%C3%B3nyuge&es_applicant_marital_status=Viuda%2Fo&es_applicant_citizen_status=S%C3%AD&es_applicant_care_for_child=S%C3%AD&es_applicant_paid_funeral_expenses=S%C3%AD&es_deceased_date_of_death=%7B%22month%22%3A%221%22%2C%22day%22%3A%2203%22%2C%22year%22%3A%222022%22%7D&es_deceased_death_location_is_US=S%C3%AD&es_deceased_paid_into_SS=S%C3%AD&es_deceased_public_safety_officer=No&es_deceased_miner=No&es_deceased_american_indian=No&es_deceased_died_of_COVID=S%C3%AD&es_deceased_served_in_active_military=No&shared=true'

  1. Annuity for certain military surviving spouses

Date of death eligibility should apply if the person died before 1978. I entered the date of death in 2/3/2022 and it said it met the criteria, which should not apply. image

  1. Date eligibility criteria not working for COVID-19 funeral assistance.

Entered DOD was on 2/3/2022, which is after 5/20/2020 and the criteria should be met. Yet, the criteria shows not met.

2b. When I enter the death was related to Covid 19, criteria should be met. image

  1. Eligibility of date of death for Lump-sum death benefit does not seem to be working.

The DOD eligibility should apply if the death happened within the last two years. I entered DOD was 2/3/2022 but shows not eligible.

image

  1. DOB eligibility for Survivors pension for child with disabilities not working.

Eligibility should only be for applicants under 18 years.

Entered DOB 4/5/1960, 63 years of age, and the eligibility of under 18 years shows met.

image

  1. DOD eligibility for Veterans burial allowance does not seem to be working.

Entered deceased died within the last two years 2/3/22 but the criteria was unmet. https://bears-waf.app.cloud.gov/benefits/benefit/burial_allowance_VA

User Story

Benefits should display criteria according to the answers met and benefit criteria.

Architectural Decision Records (ADRs)

No response

diegocob commented 10 months ago

Cindy requested me to lump all these tix together.

fongcindy commented 10 months ago

Hi Diego, Scott and I reviewed each of the issues you identified. It looks like on the recent version of the MVP, the criteria's are displaying correctly in the accordion results.

For the Date of death eligibility for the "annuity for certain military surviving spouse", Scott has fixed the issue (#713 ). Waiting for it to be ready for review in sandbox.

diegocob commented 10 months ago

Hi @scottqueen-bixal 2/5 of these benefits seem to be fixed.

These are still not displaying correctly:

  1. Annuity for certain military surviving spouses. @fongcindy mentioned that this is WIP.

  2. COVID-19 funeral assistance. the Covid-19 benefit criteria of having died after May 20th 2020 still does not seem to be working. I tried it with the veteran scenario and it didn't show eligible when it should have:

    image
  3. Survivors pension for child with disabilities shows "you are under 18" when the applicant is 73 years old.

These benefits are fixed:

  1. Lump-sum death benefit
  2. Veterans burial allowance
scottqueen-bixal commented 10 months ago

@diegocob try clearing cache or in an incognito tab

this is what I see

Image Image

scottqueen-bixal commented 10 months ago

Survivors pension for child with disabilities is a content entry error, https://bears-waf.app.cloud.gov/benefits/benefit/survivor_pension_child_disabled_VA shows the acceptable value as

Criteria Key Applicant date of birth Label You are under 18 years Acceptable Values >18years

5 of the other 6 under 18 evaluations are working as expected

Image

fongcindy commented 10 months ago

Scott and I have reviewed the scenario & eligibility criteria's on the English site, confirming it is functioning properly.

Next steps: 11/6: Diego, Ernesto, & Enrique are starting Spanish QA for this COVID scenario to check that the Spanish site and results match the English results and that the Spanish site is functioning properly. If there is time, can manually enter the values (from this scenarios doc) to check the site and questions etc.

Can flag issues here, but if there are a lot of issues: please create one new ticket to capture issues.

diegocob commented 10 months ago

I completed audit in ES. Seems to be working.