GSA / px-benefit-finder

1 stars 0 forks source link

Update release script #865

Closed scottqueen-bixal closed 5 months ago

scottqueen-bixal commented 7 months ago

Background

We have some incoming work that will require an update to the release task.

Release Task: https://github.com/GSA/px-benefit-finder/blob/main/.github/workflows/release-action.yml Incoming Work: https://github.com/GSA/px-benefit-finder/pull/851

Two (2) items to make note of from incoming work

Tasks

scottqueen-bixal commented 7 months ago

I noticed that we are deploying storybook to the dev env during release, seems like we would want to move away from that with our gitflow going through dev now,

https://github.com/GSA/px-benefit-finder/blob/dev/.github/workflows/release-action.yml#L62-L92

scottqueen-bixal commented 7 months ago

Scott to talk with Amy before moving forward

scottqueen-bixal commented 5 months ago

client decided they did not need the dist in the module contribution