Closed scottqueen-bixal closed 5 months ago
I noticed that we are deploying storybook to the dev env during release, seems like we would want to move away from that with our gitflow going through dev now,
https://github.com/GSA/px-benefit-finder/blob/dev/.github/workflows/release-action.yml#L62-L92
Scott to talk with Amy before moving forward
client decided they did not need the dist in the module contribution
Background
We have some incoming work that will require an update to the release task.
Release Task: https://github.com/GSA/px-benefit-finder/blob/main/.github/workflows/release-action.yml Incoming Work: https://github.com/GSA/px-benefit-finder/pull/851
Two (2) items to make note of from incoming work
npm run build
will output adist
directory with the necessary files to contribute upstream.component
ande2e
test in the pipeline without having to pass auth credentialspackage.json
rather than setting it based on.nvmrc
Tasks
./benefit-finder/dist
directory withusagov_benefit_finder/
Building & Deploying Storybook App to Dev Env
andCypres Testing
steps (https://github.com/GSA/px-benefit-finder/blob/main/.github/workflows/release-action.yml#L62-L106) to see if it would be better to use the updated Cypress action steps (https://github.com/GSA/px-benefit-finder/blob/migrate-vite/.github/workflows/cypress.yml#L38C1-L39C43)