GSA / resources.data.gov

Resources for open data and enterprise data inventory management

https://resources.data.gov/

Other

60 stars 81 forks source link

Feature/4788 migrate federation #724

Closed robert-bryson closed 1 month ago

robert-bryson commented 1 month ago

Pull Request

About

PR TASKS

[ ] The actual code changes.
[ ] Tests written and passed.
[ ] Any changes to docs?
[ ] Any new Gemfile or package.json updates to pull in?

tdlowden commented 1 month ago

Awesome, thanks @robert-bryson. Will do a more thorough review soon.

tdlowden commented 1 month ago

Ok I tried to add something in but ended up making it error.

@robert-bryson can you find a way to add in a bolded note as close to the top as possible that says it's no longer active. Something like:

NOTE: This project is no longer active. This page serves as an archive of the work performed in the past.

tdlowden commented 1 month ago

Aside from that, looks great!

robert-bryson commented 1 month ago

@tdlowden, fixed.

tdlowden commented 1 month ago

@robert-bryson Wish we could bold it, but that's how I threw an error when I tried. C'est la vie

robert-bryson commented 1 month ago

It is technically bolded, but I agree that the formatting is too subtle. Ideally would would be able to use a USWDS alert or something like that. I'll poke a bit and see if I can get the markdown to render an alert.