search

GSA / sam-design-system-site

SAM design system site
https://gsa.github.io/sam-design-system-site/
3 stars 8 forks source link

[Tables]: Should tables be part of the UI kits #16

Open joshbruce opened 8 years ago

joshbruce commented 8 years ago

Issue type

A table may be too complex of an HTML element to be considered for the UI kit given the complexity of the API that would need to be created in generating complex tables.

Is it possible to generate two types of tables, easily?

  1. A table with a header row.
  2. A table with a header row and a header column.

More complex tables would be developed ad hoc as opposed to using the kit.

diego-ruiz-rei commented 8 years ago

In CFDA, pretty much all of our tables are generated using Datatables. I currently feel like the UI kit should stick to generating simple tables or skipped all together.

joshbruce commented 8 years ago

@diego-ruiz-rei - Thanks!

What's the rationale behind using the Datatables jQuery plugin?

Also, tagging in @pammiller0 (Pam), and the TG architects @Rest-ez (Eric), @lfelikson (Leonid), and @volynsm1 (Mike) because I'm not sure we have this plugin listed in the as-is or to-be library list...??

ykhadilkar commented 8 years ago

@joshbruce Data tables are especially useful for Ajax based pagination, table search and sorting. Fits perfectly with CFDA requirements at that time.

joshbruce commented 8 years ago

@ykhadilkar-rei - Thanks, Yatin!

It seems like the full set of data needs to be there in order for it to work? Am I seeing that correctly?

Also, I'm assuming it generates its own HTML for pagination, search, and sort, which would need to be styled? Or, are we define the HTML structures for that functionality?

Sidenote: How did you manage to become a member of the GSA organizational account? I'm curious because if we can all do that, as vendors, then it would help us be able to make teams, if we need to, and increase flexibility for using GitHub.

ykhadilkar commented 8 years ago

@joshbruce not sure, possibly because of my contributions to data.gov