search

GSA / sdg-indicators-usa

U.S. National Reporting Platform for the Sustainable Development Goals
https://sdg.data.gov
MIT License
34 stars 92 forks source link

Setup gh actions #1048

Closed btylerburton closed 1 year ago

nickumia-reisys commented 1 year ago

Out of curiosity, what's the difference between Jekyll and NPM for this build process? Since Jekyll is on NPM, can't we use NPM to build it more "standard"-ly. Just mentioning since I noticed that we didn't use our reusable workflow here.

btylerburton commented 1 year ago

Jekyll is a static site generator written in Ruby, which uses Ruby bundler for most of its lifecycle operations. NPM is a JS package manager written in Node.

This repo is built upon an unsupported version of ruby (2.6). To move to the next supported version (3.1) would require us to bump the version of "jekyll-open-sdg-plugins", which then would require a complete refactor in how data sources are imported into the site. Specifying an alternate version in a .ruby-version file complicates matters because Pages.cloud.gov respects that paradigm and then will fail any new builds since 2.6 is unsupported.

Given there is no momentum to implement the scope of change required to bring this repo into our reusable flow, I implemented a custom one here. This allows us to a) get off CircleCI and b) continue building with Pages.cloud.gov if changes are needed. This seemed like the best possible approach.