GSA / search-gov-website

This is the code for the Search.gov documentation website.
https://search.gov
Other
4 stars 6 forks source link

Update Get Started “searchgov-for-federalist” #149

Closed dawnpm closed 1 year ago

dawnpm commented 1 year ago

Automatically generated by Netlify CMS

dawnpm commented 1 year ago

Noting here that https://github.com/cloud-gov/pages-uswds-jekyll/blob/main/README.md still refers to npm run federalist, so I'm leaving that one alone.

dawnpm commented 1 year ago

Also noting here that because I opened this with Netlify CMS, it didn't give me the PR template.

amanifarooque commented 1 year ago

@dawnpm could you post links to cloud.gov pages preview of the URLs that changed?

Also, we'll need to update the config.yml with the correct sidenav link for Search.gov for Cloud.gov Pages instructions. Might be a good time to add this to the header menus as well?

amanifarooque commented 1 year ago

Nevermind, was able to find it! I think redirects aren't working correctly with such a nested preview branch, but doesn't seem worth it to troubleshoot right now.

Cloud.gov Pages Instructions: https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/searchgov-for-cloudgov-pages.html

Site Launch Guide: https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/site-launch-guide.html

I would recommend editing this in code rather than NetlifyCMS since you'll need to edit a few different non-.md files:

Lastly, some of the links are not displaying correctly. Make sure you are in "Markdown" not "Rich Text" mode in NetlifyCMS if you are adding links in markdown.

dawnpm commented 1 year ago

Looks like my previous find-all was looking only in markdown files. Have updated the sidenav, added "Cloud.gov Pages Integration" to the main navigation, and updated the indexing accordion.

I think the redirects never work in preview because they are relative.

Cloud.gov Pages previews: https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/searchgov-for-cloudgov-pages.html

https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/indexing/indexing-workflow.html

https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/site-launch-guide.html

No preview for the readme, pr checklist, or the in-comment changes to the status page.

dawnpm commented 1 year ago

@amanifarooque ready for re-review.

amanifarooque commented 1 year ago

@dawnpm One last change, then I think we're set!

dawnpm commented 1 year ago

@amanifarooque which requested change is outstanding?

amanifarooque commented 1 year ago

@dawnpm The numbering issue, see above.

dawnpm commented 1 year ago

@amanifarooque which issue is that? I don't see any mention of numbers or numbering, even using ctrl-F in the source of this page. thanks!

amanifarooque commented 1 year ago

@dawnpm You should be able to see my comment now, didn't realize it wouldn't post until I officially added another review.

Preview Page: https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/searchgov-for-cloudgov-pages.html

The numbering is not consistent.

image image
dawnpm commented 1 year ago

@amanifarooque finally ready for re-review, I had to convert the list to html to get the numbering to behave.

https://cg-a72b65a7-73f0-4859-a1d7-dc953cf6ade8.app.cloud.gov/preview/gsa/search-gov-website/cms/get-started/searchgov-for-federalist/get-started/searchgov-for-cloudgov-pages.html

dawnpm commented 1 year ago

@amanifarooque ready for re-review