GSA / site-scanning

The central repository for the Site Scanning program
https://digital.gov/site-scanning
11 stars 2 forks source link

detecting og_type, og_image, og_url fields #1034

Closed ryanwoldatwork closed 1 week ago

ryanwoldatwork commented 2 weeks ago

for touchpoints.digital.gov the Site Scanning API is returning null

ss5

where the touchpoints.digital.gov html has values

ss7
gbinal commented 2 weeks ago

Will look into it. Thanks!

akuny commented 1 week ago

Great catch: previously, the scanner was looking strictly for meta elements with a property attribute set to og_image, etc. We've updated the scanner to also look for meta elements with a name attribute set to og_image, etc, as in the example of touchpoints.digital.gov shown above. This change is live and the scanner will run this evening.

gbinal commented 1 week ago

Great, thank you! I've confirmed this in the API, so we should be good now.

Thanks for finding this, @ryanwoldatwork !!

ryanwoldatwork commented 1 week ago

thanks team!