Checklist for new fields - a11y

GSA / site-scanning

The central repository for the Site Scanning program

https://digital.gov/site-scanning

11 stars 2 forks source link

Checklist for new fields - a11y #652

Open gbinal opened 12 months ago

gbinal commented 12 months ago

sample data

[x] Confirm field ID
[x] Confirm data type and nature
[x] Confirm location in the CSV
[x] Give search.gov team a heads up if order of final_url_live and target_url_redirects would change.'
[ ] Review data to make sure it aligns with existing public data (this vs. this)
[ ] Update the data dictionary
[ ] Add the fields to https://github.com/GSA/site-scanning/issues/376
[ ] Update this table
[ ] Greenlight @akuny updating the API and snapshots
[ ] Update itdb team & co.

gbinal commented 12 months ago

The field names and their locations should be:

accessibility_scan_status - after dns_scan_status
a11y_missing_img_alt_issues - at the end in its current order
a11y_html_attribute_issues - at the end in its current order
a11y_color_contrast_issues - at the end in its current order

gbinal commented 11 months ago

Alright - I'm comparing the old and new data here.

Of our 15,104 websites in a current primary snapshot, 11,710 match with an entry from the 12,970 websites in the itdashboard export.

10,480 of the 11,710 agree on the image alt text scan. 1,230 disagree.
9,031 of the 11,710 agree on the html attribute scan. 2,679 disagree.
9,670 of the 11,710 agree on the color contrast scan. 2,040 disagree.

A bigger issue is that 3,416 of the 11,710 have no scan results from the Site Scanning data because the scan failed. Note that in each of those cases though, the primary scan completed.

As a next step, we should investigate and try to remedy that high scan failure rate and then compare the data afresh.

Why do they have sites that we don't?

gbinal commented 10 months ago

Take 2 at comparing the data now that #672 is done...

New scan data | Snapshot of ITDashboard data | Analysis

12,905 in itdashboard, 14,988 from Site Scanning (2083 more). 2,024 had scans fail.

There's 11,693 that overlap between the two lists.

10,440 match image alt text, 1,253 differ.
8.968 match html alt text; 2,725 differ.
9,579 match color contrast; 2,114 differ.
10,440 of 14,988 match image alt text; 1,955 differ; 2,603 N/A (because in SS but not ITD).

gbinal commented 10 months ago

Take 3:

New scan data | Snapshot of ITDB | Analysis

12,905 in itdashboard | 15,000 in site scanning (457 failed)| 3366 don't overlap

dup link?