search

GSA / site-scanning

The central repository for the Site Scanning program
https://digital.gov/site-scanning
11 stars 2 forks source link

Prototype a DAP version scan #875

Closed gbinal closed 1 month ago

gbinal commented 7 months ago

Example of where the version number is found:

https://github.com/digital-analytics-program/gov-wide-code/blob/d9b51e823219b00739da06055ff609bcafd619f2/Universal-Federated-Analytics.js#L24

VERSION: "20240524 v7.05 - Dual Tracking",

The data field should be the version itself, or some appropriate string. Maybe what is in the quotation marks?

field id: dap_version When we're done, it'll go after dap parameters and before third party services

gbinal commented 2 months ago

This is planned out and ready for scanning in production. Let's go ahead and do that. Good work, @luke-at-flexion !!

luke-at-flexion commented 2 months ago

This work is functionally complete. The test failures in the CI pipeline were unexpected, though, and I am consulting with Andy to see how best to clear them. To my knowledge, the failures were not caused by my work.

luke-at-flexion commented 2 months ago

All test failures have been fixed and everything has been merged. This should be 100%

gbinal commented 1 month ago

Wahoo! Please send us a csv of it to give it a gander and we'll follow up.

gbinal commented 1 month ago

Alright - I've checked out the initial data and it looks great!

@luke-at-flexion - thanks for getting this one done so handily. Let's go ahead and make that field live in production, in the snapshots and in the API. Woot!