GSA / smartpay-training

Prototype for new GSA SmartPay training quizzes
8 stars 4 forks source link

Final List of Agencies & Bureaus / Sub-agencies (for launch) #209

Closed A-L33 closed 1 year ago

A-L33 commented 1 year ago
A-L33 commented 1 year ago

Additional bureaus for loading. Related to #37.

JessicaMarine1 commented 1 year ago

(deleted)

A-L33 commented 1 year ago

@rebekahperillo Take a look at the "New List" tab. We can discuss tomorrow, that was my first cut. Yellow = revision and Red = recommend take out.

rebekahperillo commented 1 year ago

@A-L33 Hi, Thanks for the first cut! I added some comments. Take a look and we can talk about it later today. Thank you!

A-L33 commented 1 year ago

Ready to groom, but will need some discussion under "New List" tab.

rebekahperillo commented 1 year ago

Please refer to the list on the tab named 8/9/23 on the following sheet:

https://docs.google.com/spreadsheets/d/1OuL7PV9nsC2c7UKAI-WkzQDsSSf4RHSsGIyU6nfTN3w/edit#gid=1150169393

AGENCIES -- Architect of the Capitol Armed Forces Retirement Home Consumer Financial Protection Bureau Consumer Product Safety Commission Corporation for National and Community Service - AmeriCorps Defense Nuclear Facilities Safety Board Denali Commission District of Columbia Equal Employment Opportunity Commission Executive Office of the President Export-Import Bank of the United States Farm Credit Administration Farm Credit System Insurance Corporation Federal Communications Commission Federal Deposit Insurance Corporation Federal Energy Regulatory Commission Federal Housing Finance Agency Federal Housing Finance Agency - OIG Federal Labor Relations Authority Federal Maritime Commission Federal Mine Safety and Health Review Commission Federal Retirement Thrift Investment Board Federal Trade Commission Gulf Coast Ecosystem Restoration Council Inter-American Foundation International Trade Commission Library of Congress Merit Systems Protection Board Millennium Challenge Corporation National Aeronautics and Space Administration National Capital Planning Commission National Endowment for the Arts National Foundation on the Arts and the Humanities National Gallery of Art National Labor Relations Board National Mediation Board National Railroad Passenger Corporation - Amtrak National Science Foundation National Transportation Safety Board Native American Tribal Governments Nuclear Regulatory Commission Occupational Safety & Health Review Commission Office of Government Ethics Office of Personnel Management Peace Corps Pension Benefit Guaranty Corporation Privacy & Civil Liberties Oversight Board Securities and Exchange Commission Selective Service System Small Business Administration Smithsonian Institution Tennessee Valley Authority U.S. Access Board U.S. African Development Foundation U.S. Agency for Global Media U.S. Chemical Safety & Hazard Investigation Board U.S. Court of Appeals for Veterans Claims U.S. Department of Agriculture U.S. Department of Commerce U.S. Department of Defense - Defense Logistics Agency U.S. Department of Defense - Department of the Air Force U.S. Department of Defense - Department of the Army U.S. Department of Defense - Department of the Navy U.S. Department of Defense - Independent Agencies U.S. Department of Education U.S. Department of Energy U.S. Department of Health and Human Services U.S. Department of Homeland Security U.S. Department of Homeland Security - OIG U.S. Department of Housing and Urban Development U.S. Department of Housing and Urban Development U.S. Department of Housing and Urban Development - OIG U.S. Department of Justice U.S. Department of Labor U.S. Department of State U.S. Department of the Interior U.S. Department of the Treasury U.S. Department of Transportation U.S. Department of Veterans Affairs U.S. Election Assistance Commission U.S. Environmental Protection Agency U.S. General Services Administration U.S. Government Accountability Office U.S. Government Publishing Office U.S. House of Representatives U.S. International Development Finance Corporation U.S. National Archives and Records Administration U.S. Senate U.S. Social Security Administration United States Postal Service United States Tax Court Other
weiwang-gsa commented 1 year ago

@A-L33 @rebekahperillo looks like there is duplicate, just double check if it is just a duplicate, not missing a different agency.

Image

A-L33 commented 1 year ago

That's a duplicate, we can remove that. Thank you and sorry!

On Mon, Aug 21, 2023 at 12:39 PM Wei Wang @.***> wrote:

@A-L33 https://github.com/A-L33 @rebekahperillo https://github.com/rebekahperillo looks like there is duplicate, just double check if it is just a duplicate, not missing a different agency.

[image: Image] https://user-images.githubusercontent.com/119954777/262088259-6ab76525-c07d-4f10-b6fd-a103f93bb5ae.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/209#issuecomment-1686663686, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX7NHCYSHXHDW2XDRZ3XWOFKVANCNFSM6AAAAAAYW4WCQU . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

weiwang-gsa commented 1 year ago

code changes are made, need to wipe off data on staging first and reload agency data on staging DB. waiting for confirmation if I can proceed DB clean up part.

A-L33 commented 1 year ago

@rebekahperillo No concerns here. Any on your end?

rebekahperillo commented 1 year ago

@A-L33 No concerns, thank you.

weiwang-gsa commented 1 year ago

@rebekahperillo @A-L33 thanks for confirmation, staging db data reloading is done. since this is no UI design change involved, this is ready for QA on staging here : https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/preview/gsa/smartpay-training/staging/

JessicaMarine1 commented 1 year ago

@A-L33 @rebekahperillo when you review this story, please make sure all the agencies and bureaus are loaded correctly for launch.

rebekahperillo commented 1 year ago

@mark-meyer @weiwang-gsa Do I have admin access on staging? I'm getting an error. Let me know, thank you!

weiwang-gsa commented 1 year ago

@rebekahperillo yes, I just verified from backend, you are admin on staging, you have both admin and reporting roles. I also assigned myself admin role just now, seems working fine for the admin portal. I am wondering what is the error you are getting?

rebekahperillo commented 1 year ago

I was getting an authentication error. I'll try again in a bit.

Thank you, Wei!

Rebekah Knouse Perillo (she/her)

Lead Business Management Specialist

Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration

301-938-5257

@.***

Follow the GSA SmartPay program on social media...Tweet with us on Twitter https://twitter.com/GSASmartPayNews and friend us on Facebook https://www.facebook.com/GSASmartPayNews/! [image: image.png]

On Fri, Aug 25, 2023 at 1:57 PM Wei Wang @.***> wrote:

@rebekahperillo https://github.com/rebekahperillo yes, I just verified from backend, you are admin on staging, you have both admin and reporting roles. I also assigned myself admin role just now, seems working fine for the admin portal. I am wondering what is the error you are getting?

— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/209#issuecomment-1693737845, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7Z6HESRCP5S3UXBWKEM6UTXXDROPANCNFSM6AAAAAAYW4WCQU . You are receiving this because you were mentioned.Message ID: @.***>

rebekahperillo commented 1 year ago

@weiwang-gsa Checking this out now.

Can you make sure to order these as follows? I double checked here to see how others order the agencies that have "of the" in their title: https://www.usa.gov/agency-index/d#D

U.S. Department of State U.S. Department of the Interior U.S. Department of the Treasury U.S. Department of Transportation

I'll also check the bureaus.

rebekahperillo commented 1 year ago

Bureaus for the following agencies look good:

Treasury Commerce Education GSA NSF VA HHS USDA Justice Transportation

@weiwang-gsa So, if you can make that order change noted in the comment above, then I should be ready to move this over to DONE. If you have any questions, please let me know. Thank you!

weiwang-gsa commented 1 year ago

@rebekahperillo For alphabetical order, capital letter goes first than lower letters, based on your comment above, seems you want the sort order by alphabetic order but ignore case for both agency and bureau? Just want to confirm before I make changes.

rebekahperillo commented 1 year ago

@weiwang-gsa I think Interior and Treasury get lost in the current list as displayed. I looked at some more examples and found an order that I like better than my original suggestion (federal sites are not consistent with how they handle the ordering of these two agencies).

On WhiteHouse.gov, they have

I think this will work best. Please let me know if you have any questions.

Thanks for your patience and flexibility.

weiwang-gsa commented 1 year ago

@rebekahperillo @A-L33 @JessicaMarine1 current DB structure, there is no sort_order column in agency table to support manual order, we can do following:

1.Sort by agency name alphabetically but also taking case into consideration, capital letter will order first then lower letter, so "Transportation" goes first then followed "the". Which is currently order:

U.S. Department of Transportation U.S. Department of Veterans Affairs U.S. Department of the Interior U.S. Department of the Treasury

2.Sort by agency name alphabetically but ignore case, I can convert all agency name to lower case first then sort by name alphabetically, the order will be:

U.S. Department of the Interior U.S. Department of the Treasury U.S. Department of Transportation U.S. Department of Veterans Affairs

Original user story is to sort by agency name and bureau alphabetically, last sprint review, we made "Other" as exception as it is can be put at the end of the list, the rest are sort by alphabetically. If you want Transportation in between interior and Treasury, that is breaking alphabetic order, and with current DB structure, it not easy to do without making customized code complex and harder to understand, changing DB structure at current stage is not suggested, maybe it can be post MVP item if you really want it that way, maybe we can discuss it at team meeting?

rebekahperillo commented 1 year ago

Let's do #2. Thank you for discussing!

weiwang-gsa commented 1 year ago

@rebekahperillo sort order is updated to sort by name alphabetically ignoring case, it is ready for QA review: https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/preview/gsa/smartpay-training/staging/

rebekahperillo commented 1 year ago

@weiwang-gsa Looks good, moving to DONE! Thank you!