Closed A-L33 closed 1 year ago
Additional bureaus for loading. Related to #37.
Department of Health and Human Services
Administration for Children and Families (ACF) Administration for Community Living (ACL) Agency for Healthcare Research and Quality (AHRQ) Agency for Toxic Substances and Disease Registry (ATSDR) Assistant Secretary for Preparedness and Response (ASPR) Centers for Disease Control and Prevention (CDC) Centers for Medicare & Medicaid Services (CMS) Health Resources and Services Administration (HRSA) Food and Drug Administration (FDA) Indian Health Service (IHS) National Institutes of Health (NIH) Office of the Inspector General (OIG) Office of the Secretary (OS) Substance Abuse and Mental Health Services Administration (SAMHSA) Other
Department of Veterans Affairs
Departmental Administration Offices National Cemetery Administration Office of Information Technology Office of Inspector General Veterans Health Administration Veterans Benefits Administration Other
Department of Commerce
Bureau of Economic Analysis Bureau of Industry and Security Economic Development Administration FirstNet International Trade Administration Minority Business Development Agency National Institute of Standards and Technology National Oceanic and Atmospheric Administration National Technical Information Service National Telecommunications and Information Administration US Census Bureau US Patent and Trademark Office Other
(deleted)
@rebekahperillo Take a look at the "New List" tab. We can discuss tomorrow, that was my first cut. Yellow = revision and Red = recommend take out.
@A-L33 Hi, Thanks for the first cut! I added some comments. Take a look and we can talk about it later today. Thank you!
Ready to groom, but will need some discussion under "New List" tab.
Please refer to the list on the tab named 8/9/23 on the following sheet:
@A-L33 @rebekahperillo looks like there is duplicate, just double check if it is just a duplicate, not missing a different agency.
That's a duplicate, we can remove that. Thank you and sorry!
On Mon, Aug 21, 2023 at 12:39 PM Wei Wang @.***> wrote:
@A-L33 https://github.com/A-L33 @rebekahperillo https://github.com/rebekahperillo looks like there is duplicate, just double check if it is just a duplicate, not missing a different agency.
[image: Image] https://user-images.githubusercontent.com/119954777/262088259-6ab76525-c07d-4f10-b6fd-a103f93bb5ae.png
— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/209#issuecomment-1686663686, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3ZOXX7NHCYSHXHDW2XDRZ3XWOFKVANCNFSM6AAAAAAYW4WCQU . You are receiving this because you were mentioned.Message ID: @.***>
-- Andrew Lee Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration
code changes are made, need to wipe off data on staging first and reload agency data on staging DB. waiting for confirmation if I can proceed DB clean up part.
@rebekahperillo No concerns here. Any on your end?
@A-L33 No concerns, thank you.
@rebekahperillo @A-L33 thanks for confirmation, staging db data reloading is done. since this is no UI design change involved, this is ready for QA on staging here : https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/preview/gsa/smartpay-training/staging/
@A-L33 @rebekahperillo when you review this story, please make sure all the agencies and bureaus are loaded correctly for launch.
@mark-meyer @weiwang-gsa Do I have admin access on staging? I'm getting an error. Let me know, thank you!
@rebekahperillo yes, I just verified from backend, you are admin on staging, you have both admin and reporting roles. I also assigned myself admin role just now, seems working fine for the admin portal. I am wondering what is the error you are getting?
I was getting an authentication error. I'll try again in a bit.
Thank you, Wei!
Rebekah Knouse Perillo (she/her)
Lead Business Management Specialist
Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration
301-938-5257
@.***
Follow the GSA SmartPay program on social media...Tweet with us on Twitter https://twitter.com/GSASmartPayNews and friend us on Facebook https://www.facebook.com/GSASmartPayNews/! [image: image.png]
On Fri, Aug 25, 2023 at 1:57 PM Wei Wang @.***> wrote:
@rebekahperillo https://github.com/rebekahperillo yes, I just verified from backend, you are admin on staging, you have both admin and reporting roles. I also assigned myself admin role just now, seems working fine for the admin portal. I am wondering what is the error you are getting?
— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/209#issuecomment-1693737845, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7Z6HESRCP5S3UXBWKEM6UTXXDROPANCNFSM6AAAAAAYW4WCQU . You are receiving this because you were mentioned.Message ID: @.***>
@weiwang-gsa Checking this out now.
Can you make sure to order these as follows? I double checked here to see how others order the agencies that have "of the" in their title: https://www.usa.gov/agency-index/d#D
U.S. Department of State U.S. Department of the Interior U.S. Department of the Treasury U.S. Department of Transportation
I'll also check the bureaus.
Bureaus for the following agencies look good:
Treasury Commerce Education GSA NSF VA HHS USDA Justice Transportation
@weiwang-gsa So, if you can make that order change noted in the comment above, then I should be ready to move this over to DONE. If you have any questions, please let me know. Thank you!
@rebekahperillo For alphabetical order, capital letter goes first than lower letters, based on your comment above, seems you want the sort order by alphabetic order but ignore case for both agency and bureau? Just want to confirm before I make changes.
@weiwang-gsa I think Interior and Treasury get lost in the current list as displayed. I looked at some more examples and found an order that I like better than my original suggestion (federal sites are not consistent with how they handle the ordering of these two agencies).
On WhiteHouse.gov, they have
I think this will work best. Please let me know if you have any questions.
Thanks for your patience and flexibility.
@rebekahperillo @A-L33 @JessicaMarine1 current DB structure, there is no sort_order column in agency table to support manual order, we can do following:
1.Sort by agency name alphabetically but also taking case into consideration, capital letter will order first then lower letter, so "Transportation" goes first then followed "the". Which is currently order:
U.S. Department of Transportation U.S. Department of Veterans Affairs U.S. Department of the Interior U.S. Department of the Treasury
2.Sort by agency name alphabetically but ignore case, I can convert all agency name to lower case first then sort by name alphabetically, the order will be:
U.S. Department of the Interior U.S. Department of the Treasury U.S. Department of Transportation U.S. Department of Veterans Affairs
Original user story is to sort by agency name and bureau alphabetically, last sprint review, we made "Other" as exception as it is can be put at the end of the list, the rest are sort by alphabetically. If you want Transportation in between interior and Treasury, that is breaking alphabetic order, and with current DB structure, it not easy to do without making customized code complex and harder to understand, changing DB structure at current stage is not suggested, maybe it can be post MVP item if you really want it that way, maybe we can discuss it at team meeting?
Let's do #2. Thank you for discussing!
@rebekahperillo sort order is updated to sort by name alphabetically ignoring case, it is ready for QA review: https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/preview/gsa/smartpay-training/staging/
@weiwang-gsa Looks good, moving to DONE! Thank you!
[ ] Update the list of agencies in the system to match the 8/9/23 tab in the spreadsheet.
[ ] See below for additional bureaus that need to be added.
[ ] Add option "Other" as the last item in the agency and bureau lists.