Closed JessicaMarine1 closed 1 year ago
@A-L33 I would recommend re-ordering the bureaus for each agency so that the bureaus are in the alphabetical order
Got it! Changed.
How's this? Note: Because combobox accessibility issues still aren't resolved in USWDS, let's just a regular select box for agency (as currently implemented) and subagency.
Looks great!
Weird question... do we want an "Other" bureau to be a catch all? After thinking about it, I don't know if it's something that would be helpful. Might be something we want to test with the A/OPCs after we build it. I'm inclined to take out Other... thoughts?
@JessicaMarine1 and I chatted a bit about the combobox accessibility issues. Because the issues still aren't resolved in USWDS, let's just a regular select box instead for agency (so it remains the same as it is now) and subagency.
@A-L33 I think this is something that the program needs to decide. Since it will be a required field, are we sure all the options listed (if we exclude "other") will cover all users from a particular agency?
Weird question... do we want an "Other" bureau to be a catch all? After thinking about it, I don't know if it's something that would be helpful. Might be something we want to test with the A/OPCs after we build it. I'm inclined to take out Other... thoughts?
@rebekahperillo The more I think about this, the more I don't like "Other." I think either we get rid of it (with the implications Jessica mentioned) or we ask the A/OPCs if they want "Other."
@A-L33 I like "other" because I would think that the user would want to "check a box" if their bureau isn't an option. I'm not convinced that the user's bureau will ALWAYS be there....
@weiwang-gsa Bureau list is good to go for this story. I'll include any other agency/bureaus as a new story.
@A-L33 question, previously in agency list, there is "Department of Agriculture", and here it is "United States Department of Agriculture", which one you want it to stand for agency name?
On their site, they say: U.S. Department of Agriculture. I would go with that.
Andrew, your thoughts?
Rebekah Knouse Perillo Business Management Specialist Center for Charge Card Management Office of Professional Services and Human Capital Categories Federal Acquisition Service, U.S. General Services Administration
301-938-5257 Follow the GSA SmartPay program on social media...Tweet with us on Twitter https://twitter.com/GSASmartPayNews and friend us on Facebook https://www.facebook.com/GSASmartPayNews/!
[image: image.png]
On Fri, Jun 2, 2023 at 12:24 PM Wei Wang @.***> wrote:
@A-L33 https://github.com/A-L33 question, previously in agency list, there is "Department of Agriculture", and here it is "United States Department of Agriculture", which one you want it to stand for agency name?
— Reply to this email directly, view it on GitHub https://github.com/GSA/smartpay-training/issues/37#issuecomment-1574006800, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7Z6HEXJ4IY6ERDINWV6FETXJIHTJANCNFSM6AAAAAAVMSAYNA . You are receiving this because you were mentioned.Message ID: @.***>
Let's use U.S. Department of Agriculture.
I'll add ^^^ to #209 -- i think we're going to have a few of these agency/bureau clean-up items before launch. Because each one would require a database migration, it's best to make them all at once.
According to our stand up conversation yesterday, I added #214 for additional agencies that are coming in. I just added HHS and Department of Commerce will submit by next Friday.
@melchoyce this ticket is ready for design review: https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/site/gsa/smartpay-training/
For the data part, I saw there is update in the bureau list ( there are others option added for last two), and maybe need update U.S. Department of Agriculture. That needs further discussion with engineers for best approach to do update scripts.
@weiwang-gsa Looks good to me!
@A-L33 It is ready for QA: https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/site/gsa/smartpay-training/
@weiwang-gsa Is it possible to change the order of the bureaus? They are listed in the acceptance criteria in alphabetical order. Or should we move this to #214?
@A-L33 current code is order the list by name in ascending order, seems in postgressSQL "order by" by default doesn't take special character into consideration, it treat U.S. same as US , I am working on adding collation to it. should put all U.S. first then followed by US.
@weiwang-gsa For the Department of Transportation, the bureaus look like they might be in loose reverse order. Also, is there a way to anchor "other" to the bottom of the list?
@A-L33 ohh, I thought previously you are talking about Agencies order, For bureaus, you want the "Other" to be the last item in the bureau list? that is not by alphabetic order then, that will need to introduce new column in table like "sort_order", then it can support the specific order you want item to be displayed on UI. for that case, it will require database structure change and along with all the code update, then it will be better tracked in another story
@weiwang-gsa Understood. Is there an easy way for the bureaus to be listed alphabetically (we can leave "other" where it shows up on the list for now0? Or does alphabetizing the bureaus need to be tracked in another story too?
@A-L33 the code change are made to main branch, bureaus are sorted by alphabetic order now. You may need to clear your cache to see the result change. https://federalist-2e11f2c8-970f-44f5-acc8-b47ef6c741ad.sites.pages.cloud.gov/site/gsa/smartpay-training/
Thank you! Done!
For CFO Act agency users, there is a need for more granular reporting at the "bureau" level. To accommodate that need, during the "registration" process, users should select a bureau, as needed.
Acceptance Criteria:
Department of Education
Department of Transportation
National Science Foundation
General Services Administration
-United States Department of Agriculture