search

GSA / smartpay-training

Prototype for new GSA SmartPay training quizzes
8 stars 4 forks source link

Training Site Header USWDS #431

Closed johnbeallgsa closed 9 months ago

johnbeallgsa commented 11 months ago

As a user, I would like to see the header more clearly.

Acceptance Criteria.

johnbeallgsa commented 11 months ago

Currently:

Image

Recommendation:

Image

JennaySDavis commented 11 months ago

#431 Acceptance Criteria

Pass/Fail Description
Pass Padding the dark grey border (making it wider) and shortening the header to GSA SmartPay® Training to give the user's eyes more space around this particular header

Comments/Additional Notes

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 100
Accessibility 96
Best Practices 100

Tested By Jennifer Davis on 11/6/2023

rebekahperillo commented 11 months ago

@JennaySDavis Padding and title change on staging look great! Just noticed that the Accessibility score is at 96. I thought the goal was to be at 98 or greater. Before moving this to done, should we be concerned about the Accessibility score at 96? Let us know what you think. Thank you!

JennaySDavis commented 11 months ago

@rebekahperillo, we can improve upon it. The accessibility score picked up everything on that page, not just inclusive of the Header change. I would suggest we create a bug ticket for the accessibility issue found on the page that affected the score. We can link it to this story for tracking purposes, as I would need to work with Dan to determine the development effort to fix the changes needed for the issue listed below. The issue with the page is the following: Elements with visible text labels do not have matching accessible names.

rebekahperillo commented 11 months ago

@JennaySDavis #441 has been created to address the bug that lowered the accessibility score. Would you recommend that we move this story to done with the understanding that we'll fix the accessibility issues in a future sprint or should the bug be addressed now before moving the story to done?

Do you happen to know the accessibility score before the header change? Just curious. Thank you!

JennaySDavis commented 11 months ago

@rebekahperillo I did not run any accessibility testing on the screen prior to the change request in this story were executed.

rebekahperillo commented 11 months ago

Got it, thank you @JennaySDavis (@johnbeallgsa FYI).

I'm not sure if you saw my other question.

Would you recommend that we move this story to done with the understanding that we'll fix the accessibility issues in a future sprint or should the bug be addressed now before moving the story to done?

JennaySDavis commented 11 months ago

As the AC was met, I would be comfortable moving this story as done. I see the Accessibility issue found as outside of this ticket.

rebekahperillo commented 11 months ago

@JennaySDavis Makes sense. @johnbeallgsa, feel free to move to done if you're comfortable in doing so.

johnbeallgsa commented 11 months ago

Thank you @JennaySDavis & @rebekahperillo. I will move this ticket to done with a discussion on bug #441 in the next planning/grooming session. Moved to Done.