GSA / smartpay-training

Prototype for new GSA SmartPay training quizzes
8 stars 4 forks source link

Download Name for Tab and PDF Saving Needs Corrected #460

Open LoraBradford opened 7 months ago

LoraBradford commented 7 months ago

When viewing all trainings in the "view and print" tab, all show "Training Travel" instead of correct subject training. It shows Training Travel on the top window tab and the save name default when downloading the PDF of the training.

Purchase Training for Card/Account Holders and Approving Officials reads "Training Travel" but should read "Purchase Training" Purchase Training for Agency/Organization Program Coordinators (A/OPCs) reads "Training Travel" but should read "Purchase Training" Fleet Training for Agency/Organization Program Coordinators (A/OPCs) reads "Training Travel" but should read "Fleet Training"

john-labbate commented 3 weeks ago

Also updating the "Training Travel" pages to be "Travel Training" for consistency

JennaySDavis commented 1 week ago

#460 Acceptance Criteria

Pass/Fail Description
Pass Purchase Training for Card/Account Holders and Approving Officials should read "Purchase Training"
Pass Purchase Training for Agency/Organization Program Coordinators (A/OPCs) should read "Purchase Training"
Pass Fleet Training for Agency/Organization Program Coordinators (A/OPCs) should read "Fleet Training"

Comments/Additional Notes I created a ticket for an accessibility issue with buttons not having accessible names. See Accessibility Bug: Buttons without Accessible Names on all Trainings Print Training Functionality #591

ADA Compliance (Automated scan via Chrome Lighthouse)

Criteria Score
Performance 97
Accessibility 94
Best Practices 100

Passed 06/24/2024 - JSD

johnbeallgsa commented 1 week ago

Looks great. Moving to done!