Gsa/issue 54/update dropdown

GSA / smartpay-training

Prototype for new GSA SmartPay training quizzes

8 stars 4 forks source link

Gsa/issue 54/update dropdown #689

Closed felder101 closed 1 month ago

felder101 commented 1 month ago

Replaced USWDS select component with USWDS component for agency and bureau fields. Changes were made on loginless flow page, admin user edit, and generate training report.

john-labbate commented 1 month ago

Sorry going to ask for a few additional things here.

Can you please move USWDSComboBox under the form-components folder and update any references to the new path.
We are missing test for that file as well. Its one of the components we inherited without them. Please take this opportunity to add at least a few basic ones into the system. See ValidatedMemorableDatepicker.spec.js for some quick ones you can copy and modify.

Otherwise it looks good.