Closed JessicaMarine1 closed 1 year ago
Hero image:
@brentryanjohnson when you get a chance, would mind provide alt description for three images Mel posted above ( 889 tool search, us map and forum), thank you so much!
Here you go, @weiwang-gsa!
Three panels from a screen, the first panel has a magnifying glass and reads use the 889 search to find your vendor, the second panel has a green check mark and reads in compliance with Section 889, and third panel has a red exclamation mark and reads not in compliance with Section 889.
A map of the contiguous United States with Utah highlighted in a darker color than the rest of the states, with Alaska, Hawaii, and U.S territories also shown.
An illustration of a computer display showing a blue, red, and green charge card in a panel on one side and an illustration of a person wearing a headset and microphone in a panel on the other side
@brentryanjohnson Thank you so much for all the help! @klohman this is ready for design review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
@weiwang-gsa
Here's a few items I noticed when reviewing.
The logo is slightly larger than in mockup. Using the inspect tool, I decreased the height from 6rem to 5rem and that looks about right.
Colors
H2 heading size is slightly small.
Body text
Current nav item Policy&Audits
should be Policies & Audits
(with spaces around &
).
@klohman code updates are made, ready for design review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
@klohman per today's meeting decision, would you mind providing the navigation for the home page links?
@weiwang-gsa I think this doc should help: https://docs.google.com/spreadsheets/d/1-nIXpGYsCgKcrXA4LLTEECBILCZOVWmn4n4abvFJGZU/edit#gid=0. It includes all the URL paths
Also, fwiw, I would leave the 889 tool linking out to the tool (889.smartpay.gsa.gov) not taking it to the 889 landing page within the site. cc: @klohman
@klohman per today's meeting decision, would you mind providing the navigation for the home page links?
- main navigation menu items and its URL. e.g. what are the menu items for About, and these menu items's URL.
- Other links on home page, I saw you just updated those. just double check 889 tool is not link to 889.smartpay.gsa.gov?
Link to the 889 tool at 889.smartpay.gsa.gov (see Jessica's comment)
code update checked in, and PR created, once PR is approved, will merge it into main
@klohman code update is in place, it is ready for design review : https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
Please note, if the links leads to page that hasn't been built, it will render 404 errors. Thanks!
@weiwang-gsa
Other than that, all the links seem to be pointed at the right pages
@klohman State Tax Forms duplication issue is addressed, you can review it here: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/, if it looks good to you, please feel free to move it to Ready for QA, thank you
@rebekahperillo this is ready for your review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
Wow! This looks really great! Nice work everyone! Moving over to done! :)
Path: smartpay.gsa.gov/ File name: Design: Home Template: Homepage Template