GSA / smartpay-website

SmartPay website
https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
3 stars 0 forks source link

Homepage #135

Closed JessicaMarine1 closed 1 year ago

JessicaMarine1 commented 1 year ago

Path: smartpay.gsa.gov/ File name: Design: Home Template: Homepage Template


melchoyce commented 1 year ago

Hero image: SP Program Hero

melchoyce commented 1 year ago

Image Image Image

weiwang-gsa commented 1 year ago

@brentryanjohnson when you get a chance, would mind provide alt description for three images Mel posted above ( 889 tool search, us map and forum), thank you so much!

brentryanjohnson commented 1 year ago

Here you go, @weiwang-gsa!

Three panels from a screen, the first panel has a magnifying glass and reads use the 889 search to find your vendor, the second panel has a green check mark and reads in compliance with Section 889, and third panel has a red exclamation mark and reads not in compliance with Section 889. Three panels from a screen, the first panel has a magnifying glass and reads use the 889 search to find your vendor, the second panel has a green check mark and reads in compliance with Section 889, and third panel has a red exclamation mark and reads not in compliance with Section 889.

A map of the contiguous United States with Utah highlighted in a darker color than the rest of the states, with Alaska, Hawaii, and U.S territories also shown. A map of the contiguous United States with Utah highlighted in a darker color than the rest of the states, with Alaska, Hawaii, and U.S territories also shown.

An illustration of a computer display showing a blue, red, and green charge card in a panel on one side and an illustration of a person wearing a headset and microphone in a panel on the other side An illustration of a computer display showing a blue, red, and green charge card in a panel on one side and an illustration of a person wearing a headset and microphone in a panel on the other side

weiwang-gsa commented 1 year ago

@brentryanjohnson Thank you so much for all the help! @klohman this is ready for design review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/

klohman commented 1 year ago

@weiwang-gsa

Here's a few items I noticed when reviewing.

Images

Image

Image

Universal updates

Business Lines section

brentryanjohnson commented 1 year ago

Current nav item Policy&Audits should be Policies & Audits (with spaces around &).

weiwang-gsa commented 1 year ago

@klohman code updates are made, ready for design review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/

weiwang-gsa commented 1 year ago

@klohman per today's meeting decision, would you mind providing the navigation for the home page links?

  1. main navigation menu items and its URL. e.g. what are the menu items for About, and these menu items's URL.
  2. Other links on home page, I saw you just updated those. just double check 889 tool is not link to 889.smartpay.gsa.gov?
JessicaMarine1 commented 1 year ago

@weiwang-gsa I think this doc should help: https://docs.google.com/spreadsheets/d/1-nIXpGYsCgKcrXA4LLTEECBILCZOVWmn4n4abvFJGZU/edit#gid=0. It includes all the URL paths

Also, fwiw, I would leave the 889 tool linking out to the tool (889.smartpay.gsa.gov) not taking it to the 889 landing page within the site. cc: @klohman

klohman commented 1 year ago

@klohman per today's meeting decision, would you mind providing the navigation for the home page links?

  1. main navigation menu items and its URL. e.g. what are the menu items for About, and these menu items's URL.
  2. Other links on home page, I saw you just updated those. just double check 889 tool is not link to 889.smartpay.gsa.gov?

1) Main nav links

About

How It Works

Stakeholders

Merchants = merchants/merchant-overview

State Tax Information

Policies & Audits

Resources

2) 889 tool link

Link to the 889 tool at 889.smartpay.gsa.gov (see Jessica's comment)

weiwang-gsa commented 1 year ago

code update checked in, and PR created, once PR is approved, will merge it into main

weiwang-gsa commented 1 year ago

@klohman code update is in place, it is ready for design review : https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/

Please note, if the links leads to page that hasn't been built, it will render 404 errors. Thanks!

klohman commented 1 year ago

@weiwang-gsa

Image

Other than that, all the links seem to be pointed at the right pages

weiwang-gsa commented 1 year ago

@klohman State Tax Forms duplication issue is addressed, you can review it here: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/, if it looks good to you, please feel free to move it to Ready for QA, thank you

JessicaMarine1 commented 1 year ago

@rebekahperillo this is ready for your review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/

rebekahperillo commented 1 year ago

Wow! This looks really great! Nice work everyone! Moving over to done! :)