GSA / smartpay-website

SmartPay website
https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
3 stars 0 forks source link

Mobile Review #248

Closed JessicaMarine1 closed 1 year ago

JessicaMarine1 commented 1 year ago

As a user, I want to be able to easily navigate the program site on my mobile device.

Acceptance Criteria:

klohman commented 1 year ago

Review comments

1. Logo

2. Button alignment

3. Menu

4. Smart Bulletins table

@brentryanjohnson Do you have any other comments to add?

brentryanjohnson commented 1 year ago

5. Logo

The SmartPay logo doesn't sufficiently resize to its container on smaller viewports, causing it to collide with divs both above and below it.

Content page

Screenshot with GSA SmartPay logo leaking above and below div borders

Homepage

Screenshot of SmartPay homepage on mobile with logo escaping borders


6. Image resolution

Card images in particular are pixelated and blurry on mobile. I suspect this might be due to the retina display. We might want to consider bumping the resolution to 2x the rendered size to fix this problem on retina display.

Screenshot of smartpay website with pixelated image of red charge card Screenshot of smartpay website with pixelated image of red charge card on blue background

7. Table borders

I'm not sure what's causing this, but the table borders in certain instances have a double border under certain cells. For example, on Smart Bulletins, the table border is doubled only in the Title column.

Screenshot of SmartPay website showing space between paragraph lines

8. Tight space on image wrap

Screenshot of Smartpay website showing the text Purchase really close to image of red charge card

9. Overly generous line height on intro text

Screenshot of smartpay image highlighting space between lines of text

weiwang-gsa commented 1 year ago

@klohman @brentryanjohnson this is ready for design review: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/preview/gsa/smartpay-website/staging/

klohman commented 1 year ago

@weiwang-gsa The purchase card image is not displaying like the others when I view the homepage.

image

weiwang-gsa commented 1 year ago

@klohman code changes are merged into staging, can be reviewed here: https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/preview/gsa/smartpay-website/staging/

klohman commented 1 year ago

@rebekahperillo @A-L33 Ready for QA

rebekahperillo commented 1 year ago

@klohman Wow, looking sharp on mobile! Moving to "DONE". Thank you!