GSA / smartpay-website

SmartPay website
https://federalist-ab31a10d-375d-4040-9324-1ae94e8a36b9.sites.pages.cloud.gov/site/gsa/smartpay-website/
3 stars 0 forks source link

Update USWDS from 3.71 to 3.8 | Program Website #477

Closed JennaySDavis closed 5 months ago

JennaySDavis commented 5 months ago

https://github.com/uswds/uswds/releases/tag/v3.8.0

CodyHinze commented 5 months ago

The work on this ticket included a Astro template change that affected all pages with Side Navigation. A identical change was made to all pages templates including the templates used by pages in the paths listed below.

The change will be not be noticeable as it is just a code change that duplicates the side bar navigation in code so it is in the correct accessible DOM order in HTML on Mobive devices below the content area of each screen.

Pages in the following paths were affected and can be used for testing/validation:

During testing the only noticeable change should be that lAccessibility testing tools like Lighthouse no longer report the side navigation as being outside the reading order on mobile screen sizes.

JennaySDavis commented 4 months ago

#477 Acceptance Criteria

Pass/Fail Description
Pass Smoke Testing of Program Website system updated USWDS library from 3.71 to 3.8

Comments/Additional Notes A Link checker was completed on the app - no broken links.

ADA Compliance (Automated scan via Chrome Lighthouse) This USWDS library change has been tested for ADA Compliance with USWDS.

Passed 04/1/2024 - JSD

LoraBradford commented 4 months ago

Moving to done, thank you!