search

GSA / us-data-federation

U.S. Data Federation website
https://federation.data.gov
Other
10 stars 10 forks source link

(style) add outline to links and remove unnecessary border bottom on nav items #15

Closed ftonato closed 4 years ago

juliaklindpaintner commented 5 years ago

Hello @ftonato! Thank you for your interest in contributing. Could you please provide an explanation for these proposed changes?

ftonato commented 5 years ago

Hi @juliaklindpaintner,

About my assets/css/custom.css proposes, you can see the gif bellow and check the "problem" occurrence when we scroll down and scroll up again, with the border using #fff we can see the border bottom...

border-bottom-fix

How you know, the mobile (smartphones) doesn't have hover, then we can "fix" this behaviour using :focus.

The different between :hover and :focus is: :hover when your mouse pointer is on the element. :focus when you select an element, the element gets into the focus. More Information: All CSS Pseudo Classes

I'm sorry for old update in _sass/_base.scss, my updated remove a11y-friendly, so I removed it.