search

GSA / wp2030-microsite

Workplace microsite
https://gsa.gov/workplace
1 stars 1 forks source link

update offerings page text (federal coworking teaser) #211

Closed lesliel789 closed 1 year ago

lesliel789 commented 1 year ago

On the offerings page, update the federal coworking text to:

Federal agencies share space and services in GSA owned and leased locations. Employees from several agencies will work in an open office, sharing furniture, meeting rooms, IT infrastructure, and support spaces.

JessicaMarine1 commented 1 year ago

@mark-meyer is there a way to re-center the text vertically across the picture? https://federalist-85357bc9-1249-41ef-98fc-280b69ce96be.sites.pages.cloud.gov/preview/gsa/wp2030-microsite/JessicaMarine1-patch-4/offerings/

mark-meyer commented 1 year ago

@JessicaMarine1 I think there is — The text on top is getting some extra top-margin space from the styling on the top paragraph. We would need to remove that (and make sure we don't break things on mobile).

actuallyjenn commented 1 year ago

@mark-meyer per jessica's comment to center the text on the images:

image
lesliel789 commented 1 year ago

I feel like the vertical centering isn't quite right on the federal coworking one, but since the descriptions vary in length, I think having the headings top aligned with the images may look better. @Jessica Marine - AD @.***> what was the driver or what are your thoughts on this please?

Also please remove the word "will" in the federal coworking description here: Employees from several agencies will work in an open office

Pretty sure this was my bad in submitting the content change - sorry. Thanks, Leslie

On Fri, Mar 3, 2023 at 9:53 AM Jenn Noinaj @.***> wrote:

@mark-meyer https://github.com/mark-meyer per jessica's comment to center the text on the images: [image: image] https://user-images.githubusercontent.com/6501138/222764704-88edca45-520b-4aba-bf00-0e44dd8a4f21.png

— Reply to this email directly, view it on GitHub https://github.com/GSA/wp2030-microsite/issues/211#issuecomment-1453736698, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SCTICMV7MLCXNUQQBKWETW2IHYHANCNFSM6AAAAAAVMNN2AE . You are receiving this because you authored the thread.Message ID: @.***>

mark-meyer commented 1 year ago

Hi @lesliel789 I tried aligning the text to the top per your suggestion and I think it looks good (I also removed "will").

It's up on the staging branch.

lesliel789 commented 1 year ago

All looks good thanks! Moving to done.