GSA / wp2030-microsite

Workplace microsite
https://gsa.gov/workplace
1 stars 1 forks source link

Curly v. straight apostrophes #217

Closed JessicaMarine1 closed 1 year ago

JessicaMarine1 commented 1 year ago

We are not consistent in how we are using apostrophes across the site:

Image

Need to:

JessicaMarine1 commented 1 year ago

@actuallyjenn Is there USWDS guidance on this?

actuallyjenn commented 1 year ago

@JessicaMarine1 i don't think there is uswds guidance on this but we should be using the default style that the font itself shows - this is usually best practice. in this case, it would be the "curly" style, which uswds uses in their own content. i'm guessing the straight came from a copy/paste.

brentryanjohnson commented 1 year ago

Keyboard shortcuts for curly quotes

weiwang-gsa commented 1 year ago

@JessicaMarine1 for markdown pages, we used the markdown-it config auto fix it, for other pages (html, .njk or quote coming from variable values), have to manually update it. This issue is ready for QA: https://federalist-85357bc9-1249-41ef-98fc-280b69ce96be.sites.pages.cloud.gov/preview/gsa/wp2030-microsite/Staging/

JessicaMarine1 commented 1 year ago

The places I identified look corrected to me. Moving to some.