GSA / wp2030-microsite

Workplace microsite
https://gsa.gov/workplace
1 stars 1 forks source link

New Insight: Build a future-ready workforce - Target production no later than 4/6 #245

Closed JessicaMarine1 closed 1 year ago

JessicaMarine1 commented 1 year ago

Please add a new insight that links out to external page:

weiwang-gsa commented 1 year ago

@SamCioffi @JessicaMarine1 the ratio for lead photo in our current system is 4:3, this issue's lead photo is way too wide, and out of ratio too much, it will got cropped, can you please let me know which portion you want it to be displayed? The first half (left) or the right half. Or is it possible to use a different image with ratio close to 4:3?

SamCioffi commented 1 year ago

Let's use the left half and crop out the portion with the person, even if it's just the graphic on white background. I don't have the right tools to crop it myself like Photoshop, but let me know if you need me to send it back to someone else for revision or formatting!

Samantha Cioffi Workplace Strategist


U.S. General Services Administration Phone: (212) 264-8212 Cell: (551) 370-4389

On Fri, Mar 31, 2023 at 2:57 PM Wei Wang @.***> wrote:

@SamCioffi https://github.com/SamCioffi @JessicaMarine1 https://github.com/JessicaMarine1 the ratio for lead photo in our current system is 4:3, this issue's lead photo is way too wide, and out of ratio too much, it will got cropped, can you please let me know which portion you want it to be displayed? The first half (left) or the right half. Or is it possible to use a different image with ratio close to 4:3?

— Reply to this email directly, view it on GitHub https://github.com/GSA/wp2030-microsite/issues/245#issuecomment-1492452015, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6WGJD5NL52CZFHTQZXDCI3W64SK5ANCNFSM6AAAAAAWFMUY2E . You are receiving this because you were mentioned.Message ID: @.***>

weiwang-gsa commented 1 year ago

@SamCioffi is below what what you want? The bottom part is white, I have to set new canvas and fille background with white to get it cropped with person.

Image

Below is 4:3 ratio can get ( Red), you can see even text get cut off. If possible, I highly suggest to choose a different lead photo.

Image

SamCioffi commented 1 year ago

Hello! The crop with person is great. Can the image be centered, so white is on top and bottom?

weiwang-gsa commented 1 year ago

@SamCioffi Thanks, since we adding fill color, I just keep the whole image and cropped on the filled in gray space, it looks like below, currently code change is under peer review. Once it passed the PR review, I will update status and provide you with Staging build URL for you to review.

Image

weiwang-gsa commented 1 year ago

@SamCioffi this issue is ready for QA: https://federalist-85357bc9-1249-41ef-98fc-280b69ce96be.sites.pages.cloud.gov/preview/gsa/wp2030-microsite/Staging/

SamCioffi commented 1 year ago

@weiwang-gsa Is it possible to still crop less on the image of Nina on the article page? I'd prefer if her hair were not cropped out. I also feel as though it is too close to her face. Please let me know if we need to go back to OSC for another image, but I'd assume all of our portraits are in vertical format!

The video link and thumbnail looks great. TY!

Image

SamCioffi commented 1 year ago

Moving this thread to approved as the video thumbnail and link portion are considered approved; the card associated with the Nina article link is still active. thank you!

weiwang-gsa commented 1 year ago

@SamCioffi strange, it doesn't crop on my side, this what I saw, probably you need to clear browser cache and refresh the link?

Image