Closed JessicaMarine1 closed 1 year ago
@actuallyjenn @weiwang-gsa would you mind adding the details above?
@JessicaMarine1 I added the issue details, this may not be USWDS bug, somehow it conflicts with our current offering page settings, had not figured out what is the root cause yet. I tested this morning to add in-page nav for insights page, which turns out working properly for insights page, somehow somewhere it conflicts with offerings pages, will check up with Jeff today at tech sync as he originally set the offering pages layout, he might have some insights.
@weiwang-gsa I think the behavior in the picture above is correct because "View photo gallery" is visible on the page as well.
@JessicaMarine1 the position indicator should anchor the header comes to top section. so when manually click the "Reserve space to work in our lab" it set the focus on that header, and made it the header for the top section of the screen, the position indicator also should stays on that header text for in-page Nav. This is fixed here: https://federalist-85357bc9-1249-41ef-98fc-280b69ce96be.sites.pages.cloud.gov/preview/gsa/wp2030-microsite/wwang-patch-7/offerings/innovation-lab/, will create PR
Your fix looks good! Moving to done.
@SamCioffi just letting you know that we fixed the in-page navigation scrolling issue: https://federalist-85357bc9-1249-41ef-98fc-280b69ce96be.sites.pages.cloud.gov/preview/gsa/wp2030-microsite/Staging/offerings/innovation-lab/
Current Offerings in page nav, if you manually click the in page nav section title from top to bottom, the position indicator is off. If you click nav section title from bottom up order, the position indicator is positioned correctly. It happened both on production site (USWDS 3.3.0) and with USWDS 3.4.1. See screen shot below: