GSConnect / gnome-shell-extension-gsconnect

KDE Connect implementation for GNOME
GNU General Public License v2.0
3.16k stars 255 forks source link

[TRANSLATIONS] Translators please subscribe to be notified of changes #1

Closed andyholmes closed 9 months ago

andyholmes commented 6 years ago

This is a thread for discussion of translations and notification of changes to translatable string. If you are a translator, please subscribe to this issue to be notified of changes.

Arquanite commented 6 years ago

I've made a translation for polish language, but before I contribute I wanted to test this in practice. How can I make gsconnect to use my translation? Simply pasting *.po file didn't work. Commands from wiki

ninja gsconnect-pot
ninja gsconnect-update-po

did not seems to work.

andyholmes commented 6 years ago

Sorry about that, I've changed the text domain to org.gnome.Shell.Extensions.GSConnect in git, but I usually wait until a release to update the wiki. You can use these commands:

ninja org.gnome.Shell.Extensions.GSConnect-pot
ninja org.gnome.Shell.Extensions.GSConnect-update-po

You also need to add your language to the LINGUAS file before running those commands, I'll add that to the wiki too. This is just the language code on a line by itself, eg "pl".

The change in text domain shouldn't change anything on your side, and I won't be changing it again. I also plan on putting some simple instructions for translating the WebExtension but let me know if your interested now.

Arquanite commented 6 years ago

Ok, if better instructions will be available I will make a pull request. For now I have translated po file, some other files were generated by this commands but extension still is in english.

andyholmes commented 6 years ago

Okay, I've updated the Wiki to be a little clearer about all the steps.

https://github.com/andyholmes/gnome-shell-extension-gsconnect/wiki/Translating

Let me know if you need more help getting the translation working.

andyholmes commented 6 years ago

I'm about ready to release v8, let me know if you'd like me to wait to get your translation included.

Arquanite commented 6 years ago

I've just created pull request. I'm sorry that it took so long, I had some issues with my laptop (gnome was half polish half english :o)

andyholmes commented 6 years ago

No problem, I think that was GSConnect causing that :/

shibotto commented 6 years ago

Are we supposed to fork master or v10? If it's master, po/* files are missing the gsettings.js and preferences.js merge (and the first ninja commands fail).

andyholmes commented 6 years ago

@shiba89 Sorry about that. I've sort of broken a lot of things on the way to v10 and a few commits were pushed before I made a new branch. Currently the next version is not ready to be translated and won't be until I sort some things out.

Sorry about the delayed reply.

mkey-cdx commented 6 years ago

Ok, let me know when things are ready. I'd be happy to provide you with a French translation.

andyholmes commented 6 years ago

Hello translators. I have be in conversation with the reviewers of the Gnome Extensions website and I'm planning a v9 bugfix release that will be distributed fairly soon (under a week).

There will still be many translation changes in v10, however the version to be released on the official website will be around for a fair amount of time, so if you would like to submit a new/updated translation please let me know so I can hold off before releasing.

mkey-cdx commented 6 years ago

Hello @andyholmes. As I said, I'll be able and happy to give you a French translation. This should be done within a week.

amivaleo commented 6 years ago

Hi! I've just updated the italian translation. ;)

andyholmes commented 6 years ago

@mkey-cdx sounds good, i'll let the extension reviewer know when they get back to me.

@amivaleo thanks again!

andyholmes commented 5 years ago

Hello translators!

I know it's been a long time coming, but GSConnect is now ready to accept translations for v13. You will have to pull from master, since the last development release (v13-RC1) does not include the most recent POT file. The usual instructions are available on the Translating page.

New in v13 is translatable strings from the WebExtension in the same file. Just submit your translation for the Gnome Shell extension and the next time I build the WebExtension your language will automatically be included -- no extra work!

Ubuntu 18.10 is due to be released on October 18 and that will also be the target release date for v13. However, the review process for Gnome Shell extensions is volunteer based and can be quite long, so please ask if you need more time and I will be happy to delay release.

piotrdrag commented 5 years ago

intltool-update -m is reporting these two files missing from POTFILES:

data/debug.ui
src/service/plugins/contacts.js

The first one looks like a false positive, but the second indeed looks missing.

andyholmes commented 5 years ago

Ah thanks, fixed. Yep, debug.ui I think shouldn't be translated since users (usually) shouldn't use that.

ricvelozo commented 5 years ago

Some strings are missing, like: Mute Microphone and Display Mode. Also, I tested the translation I made, and some things still appear in English.

andyholmes commented 5 years ago

Sorry, everyone! Seems like a lot of strings in the Glade files were not marked as translatable.

I've updated the translation file, so you should be able to pull from master and adjust your translation.

ricvelozo commented 5 years ago

Still some strings are missing / not getting translated:

andyholmes commented 5 years ago

Okay, hopefully I have fixed the menus being translated now. The About dialog I'll have to fix for next release. Right now it's automatically taken from metadata.json which doesn't get translated.

Edit Nope, haven't fixed it. I'm investigating why only menus aren't being translated. Edit2 Got it!

L0sted commented 5 years ago

Do Not Disturb toggle in menu and DnD duration popup are also untranslateble

andyholmes commented 5 years ago

Should be fixed now, but you have to re-pull and restart gnome shell.

ricvelozo commented 5 years ago

Nice! All right here.

andyholmes commented 5 years ago

Hi everyone, I think we're about ready to release v15 which has a few new and changed strings (v14 was a very minor release that isn't reviewed on e.g.o yet). @amivaleo your translation should already be up to date, so nothing to do for you.

The changes are pretty minor so release date will be Monday, November 5th, unless someone needs more time.

andyholmes commented 5 years ago

Sorry guys, we made a little mistake with one or two "pluralized" strings that may require an update on your part. As usual, feel free to ask for more time if you need us to hold back release.

ricvelozo commented 5 years ago

@andyholmes Some strings turned comments after update from POT... Can you check if is ok? PR https://github.com/andyholmes/gnome-shell-extension-gsconnect/pull/302

ferdnyc commented 5 years ago

I answered @ricvelozo 's question over at #302, but for the group:

The commented strings are ones that we removed from the source, or changed their (English) meaning since the last time the master .pot file was generated. They're stored in comments that way to make it clear that was intentional. (And also so any translations provided for those strings will be preserved, in case they're put back into the code at a later date.)

Vistaus commented 5 years ago

I always use Poedit, so I never see any commented strings anyway lol

ricvelozo commented 5 years ago

@ferdnyc yes, I just wanted to confirm because the last time the removal wasn't intentional. 😃

andyholmes commented 5 years ago

Hi everyone, I've just merged the new Messaging UI and between that and some other changes, there are a number of new and changed strings. I've already realigned the POT and everything for you. Here's a preview:

screenshot from 2018-11-19 11-31-27

I think this should be all for this coming release (v17) and I'm not in a rush so you have lots of time :)

andyholmes commented 5 years ago

Quick update, I just "fixed" the translations to use proper quotations, except for the ones who were already doing so. So if you had very recently pulled you may want to do so again, otherwise I'll just fix it up when you submit your PR.

piotrdrag commented 5 years ago

I can see you put a lot of work into it, so it pains me to say that maybe it was a bad idea. Every language has different rules for quotations, and I'm pretty sure at least German is wrong. It would have been best to change just the quotations in code early in the next release cycle and let translators fix their translations.

andyholmes commented 5 years ago

oh no, you're right 😟 I think i see the German error I made (and with french) hopefully, translators will fix my fixes.

ricvelozo commented 5 years ago

@andyholmes What will the release date be?

andyholmes commented 5 years ago

[pretends to type at calculator and make phone calls]

@ricvelozo Let's say Nov 26 at latest (2 weeks since last)?

There are bugs I would like to get fixed before v17, but there are a lot of fixes already. GSConnect is very large, sometimes it's reviewed faster if there's less "single" releases (reviewers don't have to restart if I post a new one).

ferdnyc commented 5 years ago

^ (I don't think I've ever been involved in a GitHub project where I haven't eventually typed "#1" in an issue comment, and accidentally created a reference to the repo's first issue. So at least that's that tradition out of the way. 🙄)

DeadMetaler commented 5 years ago

Hi. I've made a 100% translation but some string stayed in english. Why it may happend?

Send To Mobile Device All files Camera Pictures

2018-12-19 14-07-08 2018-12-19 14-04-46

andyholmes commented 5 years ago

Hi. I've made a 100% translation but some string stayed in english.

Thanks! The first screenshot looks like Firefox/Chrome, so I have to update the extension on those websites before the translation will show.

The second one is actually sent by KDE Connect Android, and our translated version only get shown in some fallback situations (very rare). I've asked the KDE Connect team where they do their translations, so I'll link you when they get back to me if you want to add the translations for that too :)

amivaleo commented 5 years ago

Uh! I'll help with the italian translation. :)

andyholmes commented 5 years ago

Cool, I'll let you know what I find out :)

andyholmes commented 5 years ago

Hi all translators, I've just pushed an updated translation template (POT). I've recently started to improve the accessibility of GSConnect (eg. screen readers, keyboard navigation), which requires more strings and testing than usual. This may take a bit of time until translations settle down.

I plan to do a release shortly after I confirm that #394 is fixed (bad memory leak). Then I will do more accessibility and UI work that could mean more translation changes and do another release fairly soon. I will let you decide when to update your translations, because I know this is a busy time of year :)

DeadMetaler commented 5 years ago

Thanks! The first screenshot looks like Firefox/Chrome, so I have to update the extension on those websites before the translation will show.

The second one is actually sent by KDE Connect Android, and our translated version only get shown in some fallback situations (very rare). I've asked the KDE Connect team where they do their translations, so I'll link you when they get back to me if you want to add the translations for that too :)

First screenshot from Nautilus right-click menu.

ferdnyc commented 5 years ago

@DeadMetaler :

Hi. I've made a 100% translation but some string stayed in english. Why it may happend?

First screenshot from Nautilus right-click menu.

The Nautilus extension code picks up its translation files from the Gnome Shell extension's install location in your user data directory: https://github.com/andyholmes/gnome-shell-extension-gsconnect/blob/398457c079ea62c9002fb7c3bc0486a833761a35/src/nautilus-gsconnect.py#L24-L30

(Typically that's $HOME/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/locale.)

So if the correct xx.mo file is present there for the locale xx, it should be picked up. Note that it's probably only checked/loaded once when the extension is started, so may have to kill and restart at least Nautilus, if not Gnome Shell, for the extension to re-load the translations. (Or log out and log in again.)

DeadMetaler commented 5 years ago

Hi all translators, I've just pushed an updated translation template (POT). I've recently started to improve the accessibility of GSConnect (eg. screen readers, keyboard navigation), which requires more strings and testing than usual. This may take a bit of time until translations settle down.

Sorry for noob question but how can I merge this changes to my translated *.po file?

andyholmes commented 5 years ago

@DeadMetaler You should be able to update your fork and then do the translation like normal. Basically just add the original (my repo) as a remote:

git remote add upstream https://github.com/andyholmes/gnome-shell-extension-gsconnect.git
git fetch

Then update/rebase your repo from mine:

git rebase upstream/master

Then do you translation updates from the POT file. Then when you push, target your repo (origin/master) and your Pull Request will be automatically updated:

git push origin master

Does that answer your question?

andyholmes commented 5 years ago

Hi everyone, over the last couple days I have been trying to setup Crowdin for GSConnect.

For some languages this seems to work well, but for others there may be some difficulties. Currently Belarusian and Estonian are setup and working.

If you have used Crowdin before and/or would like me to setup your language, please let me know and I will add it for you. The link for it is here: https://crwd.in/gsconnect

amivaleo commented 5 years ago

Here I am! Let me deal with the italian translation. :)

Vistaus commented 5 years ago

I've dealt with translations on Crowdin before, but I really dislike the translation interface and the way translation fixes aren't deal with because they are easily overlooked. So I gave up on Crowdin and would rather translate the old-fashioned way or prefer an alternative site like Weblate or Transifex.

L0sted commented 5 years ago

I want to help with russian translation