GSConnect / gnome-shell-extension-gsconnect

KDE Connect implementation for GNOME
GNU General Public License v2.0
3.16k stars 255 forks source link

[UX] received text messages (SMS) reading #1054

Open premek opened 3 years ago

premek commented 3 years ago

Is your feature request related to a problem? Please describe. When a text message is received by my phone a notification is displayed on my PC. Full text is displayed and I can read it but when for example I want to copy part of it or open a link that's in the message, I click on the notification and then "Send SMS" window is open.

Describe the solution you'd like I think this action should open a window with the received message or the window that is currently opened (Send SMS) should be changed to contain both a possibility to send messages (as it does) but also a list of received messages. Maybe make it look more like it does on phones with received messages on top with a possibility to respond.

System Details (please complete the following information):

premek commented 3 years ago

On another computer I have GSConnect 28 and when I click on the notification, this window opens, where I can copy the message text.

Screenshot from 2021-05-26 00-02-19

andyholmes commented 3 years ago

Previously this was fairly simple since only numerical phone numbers were supported, but became more complex when we added the support for e-mail addresses. For this to be fixed the replySms action will have to be updated to use some heuristics on the hint parameter:

https://github.com/GSConnect/gnome-shell-extension-gsconnect/blob/37994f2f12720d8adbe5c633210c930a2bbbaf67/src/service/plugins/sms.js#L359-L368

I think it might not be possible to do this reliably 100% of the time, but probably the common cases could be covered. Alternatively if the sms event is still supported by the telephony plugin it might be possible to leverage that information.

premek commented 3 years ago

how about just displaying the message from the notification in a window where you can copy it?

andyholmes commented 3 years ago

Sure, you could make the default just open a window, but whether that's a good idea I don't know.