search

GSConnect / gnome-shell-extension-gsconnect

KDE Connect implementation for GNOME
GNU General Public License v2.0
3.18k stars 254 forks source link

nightly noncritical error on gnome 46 #1781

Open Harv234 opened 6 months ago

Harv234 commented 6 months ago

Describe the bug

When starting up journalctl shows the following uncritical error:

gjs: Gio.UnixInputStream has been moved to a separate platform-specific library. Please update your code to use GioUnix.InputStream instead. 0 _initUdpListener() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/backends/lan.js":267:16] 1 start() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/backends/lan.js":458:21] 2 _loadBackends() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/manager.js":259:24] 3 start() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/manager.js":462:13] 4 vfunc_startup() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/daemon.js":263:21] 5 vfunc_handle_local_options() ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/daemon.js":660:17] 6 <TOP LEVEL> ["/home/harvey/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/service/daemon.js":720:16]

Steps to reproduce

journalctl -b -p4

Expected behavior

No response

GSConnect version

56 nightly 2024-April-04

Installed from

GitHub releases (zip file)

GNOME Shell version

46

Linux distribution/release

Arch

Paired device(s)

OnePlus IN2023

KDE Connect app version

1.29.0

Plugin(s)

No response

Support log

No response

Screenshots

No response

Notes

No response

andyholmes commented 6 months ago

Thanks, I forgot about this change.

Harv234 commented 5 months ago

I can confirm that the message has gone away with today's nigtly. And even better: no other messages appeared :+1:

jtojnar commented 3 months ago

User reported still getting it on 57 here:

https://github.com/GSConnect/gnome-shell-extension-gsconnect/blob/43258f924311c80744068e5af794db3c95df925f/src/preferences/service.js#L60

Apparently, it can also happen due to a gjs bug: https://gitlab.gnome.org/GNOME/gjs/-/issues/610

ferdnyc commented 3 months ago

I, too, am still getting the warning with v57, on Fedora 40 with GNOME 46. Reopening to track that straggler message.

The linked bug was fixed in gjs, but having the message go away would be dependent on using a GJS version that contains the fix. The most recent release, 1.80.2, was made a day before that fix merged.

(Edit: Sorry, actually, 1.80.2 was released a day before the fix was submitted, and 6 days before it merged.)