GSConnect / gnome-shell-extension-gsconnect

KDE Connect implementation for GNOME
GNU General Public License v2.0
3.22k stars 259 forks source link

After reboot, GSConnect re-enables itself despite not being enabled before reboot #1839

Open TuTiuTe opened 4 months ago

TuTiuTe commented 4 months ago

Describe the bug

If you disable GSConnect in the quicksettings, then restart your computer, despite the state of the GSConnect button still being grayed out, it will connect to available devices. This problem is fixed by toggling on and off the button, but still, it's a bug and I find it a bit annoying

Steps to reproduce

  1. Turn off GSConnect in Quicksettings
  2. Turn off / suspend your computer
  3. Turn on / wake your computer
  4. See the button in QS being grayed out but the pc will connect to other devices

Expected behavior

as the button is grayed out, it shouldn't connect to other

GSConnect version

57

Installed from

Extension Manager

GNOME Shell version

46

Linux distribution/release

Fedora 40

Paired device(s)

Redmi Note 10

KDE Connect app version

1.31.1

Plugin(s)

No response

Support log

No response

Screenshots

image

Notes

No response

ferdnyc commented 3 months ago

It's actually possible to get into this state through other methods that don't require a reboot.

For example, if you disconnect GSConnect by clicking the QuickSettings button, then open the preferences app and click the Refresh button in the upper-left corner, GSConnect will reconnect to paired devices despite the QuickSettings tile still being gray.

So, one bug here is that the QuickSettings tile simply doesn't accurately reflect the state of the extension.

Whether or not the disconnected state should persist across reboots is a separate question. (These might help provide an answer: Does toggling the network connection off persist across reboots? How about the Bluetooth radio? ...Things to test, but not on my primary machine while I'm actively using those features.)

Tangentially, the meaning of QuickSettings tile states is a little bit ill-defined and inconsistent between applications, seems to me. For example, on my desktop system the Power Mode tile is normally gray, with the Balanced profile active. But I can toggle it on/blue, which switches to the Performance profile.

ferdnyc commented 1 month ago

OK, I've since had a chance to test, and Bluetooth's "Airplane Mode" toggle does persist across reboots, so GSConnect's disabled state should probably do the same.

And the Refresh button in the Preferences should probably be disabled as well, while it's active. Or at least pop up a message warning that GSConnect is currently disabled, and will have to be re-enabled to perform the refresh.