andyholmes
commented
4 years ago This might be tricky to fix. It seems like kdeconnect-android is sending a player state update after it indicates the player has been removed:
// We receive an update for "YouTube", DBus interface already exists
{
"id": 1587836714617,
"type": "kdeconnect.mpris",
"body": {
"player": "YouTube",
"nowPlaying": "Fact Fiend - With Karl Smallwood - Wiki Weekends | That Time Sub-Zero Became Batman",
"title": "Wiki Weekends | That Time Sub-Zero Became Batman",
"artist": "Fact Fiend - With Karl Smallwood",
"album": "",
"isPlaying": true,
"pos": 7790,
"length": 951000,
"canPlay": true,
"canPause": true,
"canGoPrevious": false,
"canGoNext": false,
"canSeek": true,
"volume": 36
}
}
// "YouTube" is removed from the player list, DBus interface is destroyed
{
"id": 1587836714684,
"type": "kdeconnect.mpris",
"body": {
"playerList": [
"YouTube Music"
]
}
}
// We request an update for "YouTube Music"
{
"id": 1587836715508,
"type": "kdeconnect.mpris.request",
"body": {
"player": "YouTube Music",
"requestNowPlaying": true,
"requestVolume": true
}
}
// We receive an update for "YouTube", DBus interface is recreated
{
"id": 1587836714684,
"type": "kdeconnect.mpris",
"body": {
"player": "YouTube",
"nowPlaying": "Fact Fiend - With Karl Smallwood - Wiki Weekends | That Time Sub-Zero Became Batman",
"title": "Wiki Weekends | That Time Sub-Zero Became Batman",
"artist": "Fact Fiend - With Karl Smallwood",
"album": "",
"isPlaying": false,
"pos": 0,
"length": 951000,
"canPlay": true,
"canPause": true,
"canGoPrevious": false,
"canGoNext": false,
"canSeek": true,
"volume": 36
}
}I'll have a closer look at the code later tonight. It may be we can trust the player list and ignore updates from unlisted players, but that needs kdeconnect-android to be reliable about what it's sending us (which it apparently isn't sometimes).
Describe the bug
Old media controls are not cleared after being cleared from notification. They show up as playing. The Controls do nothing on surface. Any New media from app that has a notification stuck does NOT update.
Steps To Reproduce:
Expected behavior
Media notifications disappear from notification when notification is cleared or media playback stops. Changing media on phone updates the notification with new information.
Screenshots
If applicable, add screenshots to help explain your problem. You can drag-and-drop or cut-and-paste images directly into this edit window, to include them in your report.
Support Log
Please generate a support log (Instructions) and paste any messages related to this issue between the two ``` lines below.
System Details (please complete the following information):
GSConnect environment (if applicable):
Additional Notes:
Add any addtional information about the problem or your system.