Introduce a way how to deal with the data in the view.

[skaldo]

As the application gets more and more complex, we have to define a way how to deal with the preparation of data for the UI.

• [x] Check if there's any pattern in the AngularJS 2 or the Ionic 2
• [x] If there's no pattern, think of at least these two approaches:
• Do all the data processing in the controller of the given component
• Introduce a new layer in our application to which the UI (controller) can de directly connected
• Any other ideas?
• [x] Make a little summary (basically pros and cons of the approaches)
• [x] Discuss this on our weekly meeting (Thursday 09.06.2016) or via slack

Example: We want to have a filtering of the stops in our application.

1. Should we do it in the controller or in some service?
2. Should the service have a direct access to the data provided by out CDS, or should it get it from the controller?

Think of the reusability and the coupling and other SE principles :wink:.

After discussing this, we can start with coding it. Only if we all agree on the solution, we can be sure that there's no better one.

This issue is assigned to Steffen, but everyones opinion is valuable! @GSE-Project/group2

---

Since we agreed upon @themetalone s proposal on 09.06.16 we'll implement the Data Transformation Layer shown in app/providers/transformation/TransformationService

• [x] Implement the basic structure
• [x] Implement the getter
  • [x] Stops
  • [x] Busses
  • [x] Lines
  • [x] Routes
  • [x] ... ?
• [ ] Testing
  • [x] One detailed test using generics (should cover most of the service)
  • [ ] One test method for each getter
  • [ ] Integration tests
• [x] Integration into UI

[themetalone]

Haven't found any specific pattern to do this but here are my ideas: First of all, I wouldn't let the controller do data logic work. The transformation from model into view data shouldn't be part of the View Controllers responsibilities.

My Recommendation: New Layer between UI and Data Logic

We simply add another layer to our application. This layer would translate the data model into view model objects as well as filter the data. This would be similar to our very first version of the CDS.

I think this to be the most elegant and flexible approach as well as the one with the least rework effort. I'll prepare a quick demonstration for tomorrows meeting

[skaldo]

Thanks Steffen, I share you thoughts. Please do not spend too much time with the demo preparation. Just take one entity (stops) and prepare a brief demo, including how the search could look like (must not be implemented, though).

Let us discuss the details in the meeting.

[themetalone]

Found a bug that seems to be tied to #80 since it occured after updating the ionic : When entering text into the search bar, the entered text seems to be one character to slow. i.e. entering character by character the word Kirche lead to :

• Entered Text -> internal searchText
• K ->
• Ki -> K
• ...
• Kirche -> Kirch

and when removing then character by character

• Kirch -> Kirche
• Kirc -> Kirch
• ...
• `->K`

[themetalone]

I'll set this to Review as the implementation and integration are done.

[themetalone]

Further developed in #84