✔️ Feedback and Review

[sara219]

Well done everyone, you did a great job 👏🎉

👉 Check this repository to see general notes that will help you when you will work on any project in the future

👇 follow the next box to read the review and feedback

[sara219]

Teamwork Feedback

• You did a great job in that part, I liked how you worked as a team and decided everything together just for the next time, try to listen carefully to each other thought

• Don't forget that the lead mentors always happy to help you and listen to you

[sara219]

File Structure Review

when you start coding, the first step is to create the file structure that you already agreed on it in the planning phase.

the first pull request should be the file structure, merge it with main, and then all the team members will have it by cloning ( start coding your part after that)

index.html should be in the root only, other things should be included in folders: style (for CSS files), assets (for images)

index.html assets/ ├── img1.png └── img.png style/ └──style.css

[sara219]

Code Review

Code formater

Install Prettier, and make sure to activate it, it makes your code more readable and consistent with your project's style guide.

Descriptive comments

Always add and write descriptive comments in your file to explain your piece of code and use it to divide the sections. also, write comments that guide the readers

Semantic elements

Try to reduce the number of div that you use in your code, and use semantic element instead of it

Classes name

Make sure that you write a more descriptive classes name

CSS layout

when you decide to use FlexBox for layout, no need to use other methods like position, float or so many margins

Test your code

• always test if the property affect your element or it's useless, if it, remove it
• test if there is another property that can do what you want with fewer lines

[Ibrahim-Jarada]

Noted. Thank you