Hi @haitham-akram and @AyaQunoo. I hope you're enjoying your night after working hard on that project. I like your final product, the styles are cool, the console is empty and everything is clean! Excellent work!
I left some comments on your code here #20, please review them and reply there if you have any questions.
Here are some general notes to consider in your future projects:
file structure: I like that you have created a separate folder for scripts and styles but we can do better. I suggest making a folder for each page. For example a giveaway folder with index.html, index.js, and style.css. This will be so much better than having all of your styles in one file.
GOOD JOB having your code formatted and free of typos 🥳
What will happen in case of no response sent back from the API? this might be early but start to think about including fallback values. For example, if an object in the response came with no image, I can use a local image for it.
Please take your time finding names for your commit messages and pull requests and avoid things like fixes and final changes
Try to stick with a naming convention for your branches, the recommended one by GitHub is kebab-case. And close them once you're finished with them.
Don't forget about previous weeks' topics, such as testing. You got plenty of pure functions that can be tested.
That's it for me. Again, excellent work on your project. The comments I added in pr #20, are just to open your mind about writing robust code. Good Luck!
Hi @haitham-akram and @AyaQunoo. I hope you're enjoying your night after working hard on that project. I like your final product, the styles are cool, the console is empty and everything is clean! Excellent work!
I left some comments on your code here #20, please review them and reply there if you have any questions.
Here are some general notes to consider in your future projects:
scriptsandstylesbut we can do better. I suggest making a folder for each page. For example agiveawayfolder withindex.html,index.js, andstyle.css. This will be so much better than having all of your styles in one file.commitmessages andpull requestsand avoid things likefixesandfinal changeskebab-case. And close them once you're finished with them.That's it for me. Again, excellent work on your project. The comments I added in pr #20, are just to open your mind about writing robust code. Good Luck!