Pull Requests Rules

[sara219]

Steps you should follow when you will start working in an issue and create a pull request :

• Assign yourself in the issue you will work on it and add label in-progress
• Add the issue to the related project and add it to the in-progress section
• Create a new branch and be sure that it's up to date with master

Start Working

• Write a descriptive commit to show what you did and add issue number to every important commit.
• In the description, write what you did and what you change and how we can test it.
• Request a review from the team members and team leader.
• Add the label awaiting-review and wait or start working on other things

[sara219]

When the team review the pull-request :

• Read and test the code, pull it to your local machine
• if you have any comments and there is sth you want it to change write it and change the label to change-request

---

• When you get the approval from team leader and one of the member, the label will change to approved and you can merge your pull-request.
• Delete the branch
• In the project move it to Done section
• In the issue change the label to Done
• Close the issue

DONE

[sara219]

Merging Pull Requests

• • The one who opens the pull request is responsible for the final merge, but only after team lead and one of one teammate has reviewed, approved, and left a comment on the pull request to that effect