GSI-CS-CO / bel_projects

GSI Timing Gateware and Tools
14 stars 15 forks source link

Dm multi sync thread spawn and reference edges #354

Closed mkreider closed 8 months ago

mkreider commented 9 months ago

TODO: test referencing code - writeback of changes to immediate values (e.g. the rd and wr indices of a block to its command queue) if the node uses references. This works differently to nodes not using references and should be thoroughly tested

skorsky commented 9 months ago

Functional review:

  1. Old pytests work after change of thread attribute for startthread nodes in dot files. For startthread thread=1 changes to thread="0x2", thread=2 changes to thread="0x4" and so on. The value is a bitmask. Attention: no change for origin nodes. Origins must assign exactly one thread.

  2. dynpar{0,1} edges are missing after download of schedule.

  3. The validation of schedules needs a check for valid thread numbers in startthread and origin nodes.

  4. The simultaneous start of threads does not work as expected for 32 threads.

This pull request needs fixes before merge.