Extends Webui to interface with Common-adapter

zkong-gsma commented 3 years ago

Add "Service/Adapater" library to app-core to interface with common-adapter

https://github.com/GSMA-CPAS/BWRP-UI/pull/50

zkong-gsma commented 3 years ago

@sgerhardt-trilobyte

do you recommend a

├── adapter
│   ├── AbstractAdapter.js
│   ├── common
│   │   └── v1
│   │       └── CommonAdapter.js
│   
└── services
    ├── AbstractService.js
    ├── common
    │   └── v1
    │       └── CommonService.js

A new "Server + Adapter"?

then change VUE_APP_API_BASE_URL = /api/v1/blockchain

to /api/v1/common/

If so, i am happy to "clone" "BlockchainService", then remove keep only relevant "functions" in them.

let me know.

sgerhardt-trilobyte commented 3 years ago

@zkong-gsma

sounds good!

Just roll back your changes in BlockchainService and create new Service (CommonService). You already did this, perfect :)

One important thing. You added the app configuration (app-roaming) in default.json

  "apps": {
    "roaming": {
      "name": "roaming",
      "enabled": true,
      "packageName": "app-roaming",
      "displayName": "Roaming",
      "config": {
      }
    }
  },

This kind of configuration belongs in production.json. For configuration we are using the node package "config" -> https://github.com/lorenwest/node-config. This allows a customized configuration to be used for each environment (NODE_ENV). An example of a production.json can be found in dev-setup repo https://github.com/GSMA-CPAS/BWRP-development-setup/blob/master/organizations/dtag/webapp/config/production.json

zkong-gsma commented 3 years ago

sorry my bad about the Default.json.

it was my config when i was trying to get it work locally that i put it in.

I have reverted this.

sgerhardt-trilobyte commented 3 years ago

Okay, thanks! Review and testing will take place next year ...

GSMA-CPAS / BWRP-UI

Extends Webui to interface with Common-adapter #48