GSMA-CPAS / BWRP-UI

Apache License 2.0
1 stars 0 forks source link

Test Alpha Version #51

Closed fhomberg closed 3 years ago

fhomberg commented 3 years ago

Overall feedback

Contract View

General information:

Signatures:

Discount Models:

Contract Revenue Commitment

Services

Usage pricing model

Unit

Rate

Access pricing

fhomberg commented 3 years ago

@andswk @Pad-135 @zkong-gsma: I started collecting issues for the current alpha version here ...

hochbergg commented 3 years ago

@fhomberg @Pad-135 "Should be possible to add new service to overall list" - I'm not sure what this means in the context of discount agreement services. Should I allow any service the user wants to type in even if its not on the list?

Pad-135 commented 3 years ago

@fhomberg @Pad-135 "Should be possible to add new service to overall list" - I'm not sure what this means in the context of discount agreement services. Should I allow any service the user wants to type in even if its not on the list?

Hi Gal, I think you can skip it for now (no additional services foreseen on top of the standard services). We agreed for now to focus only on services defined in the xls sheet above - Standard services.. Tx.

fhomberg commented 3 years ago

@hochbergg @Pad-135: It means that right now we have services like MOC, SMS, Data ... for which we can configure discount schemes. This service list should be part of the workspace and configurable so that we can add new services like LTE-M, ViLTE etc. if required. But Pascal is right: If this is too much effort - we leave this for later. Thank you for checking back Gal!

hochbergg commented 3 years ago

@fhomberg @Pad-135 Thanks for the quick response! The way I'm implementing it is that in the future we could make it part of the workspace, but right now its a static list in the frontend.

hochbergg commented 3 years ago

@fhomberg @Pad-135 regarding "To" thresholds, they were removed as its easy to create inconsistent models with them - you must have each "To" field be equal to the "From" field after it, or your model is not well defined.

What did you mean by re-adding "To" fields?

hochbergg commented 3 years ago

PR for UI fixes available here: https://github.com/GSMA-CPAS/BWRP-UI/pull/55