UI Version 0.2.0 Issue Collection

[fhomberg]

Contract builder:

• [x] Add info in the UI error message indicating the cause for the problem (missing form fields or connectivity)
• [x] Add missing field info to UI, highlighting the entry fields that still need to be filled or a filled incorrectly. User needs to have this feedback. Currently the only feedback is "Could not save contract - the contract information may be incomplete or filled incorrectly."

Section: Contract overview

• [ ] AFTER signature on both sides, contract status still shows "sent" or "received". After both parties have FULLY signed, the contract status should change to "signed" for both sides. If the contracts have only partially been signed by either party, the status for both parties should be "partially signed". Then we know at least, that the process has been started.

Section: Workspace / TADIG Groups

• [x] Error message when trying to delete TADIG codes from existing TADIG group ("Status code 405/message undefined")
• [x] Error message when trying to delete complete TADIG group. Same error message as above @Pad-135 Can you replicate this?

Section: General Information

• [x] When selecting start/end dates 2021-01-01 to 2021-12-31, the agreement period is indicated with 11 months. Shouldn't this be 12 months?

Section: Discount Models

• [x] Condition: Unclear what the difference between "Contract Revenue Commitment" & "Deal Revenue Commitment" is @Pad-135 Do you know?
• [x] Entering new discount models for services: The "+" button to select a new service is in the first row of the service. When I want to enter a new service I always have to go up and then down again. The "+" button should therefore be at the end, after entering the rates.
• [x] If a rate of "0" is being entered, the contract can't be saved. This needs to be changed. For MTC, a rate of "0" is usual.

[andswk]

I guess this error message "Could not save contract - the contract information may me incomplete or filled incorrectly." is due to some issue in the contract builder. Probably we should add missing fields information in the UI.

[ignatov17]

Hello,

the problem: error message "Could not save contract - the contract information may me incomplete or filled incorrectly." was because of missing connectivity to ordering service. In logs there is a message: 2021-02-25T09:56:10.723Z - error: [DiscoveryService]: _buildOrderer[atomic]

• Unable to connect to the discovered orderer orderer2.hldid.org:7050 due to Error: Failed to connect before the deadline on Committer- name: orderer2.hldid.org:7050, url:grpcs://orderer2.hldid.org:7050, connected:false, connectAttempted:true

Without any touch, now service works and I can create a contract.

Can you try again, please?

Best regards, Bozhidar

На пт, 26.02.2021 г. в 13:17 ч. fhomberg notifications@github.com написа:

Overall: I was not able to save & propose contract from DTLAB to ORLABMSP. Received an error message: "Could not save contract - the contract information may me incomplete or filled incorrectly. @ignatov17 https://github.com/ignatov17 - Can you help here?

Section: Workspace / TADIG Groups

• Error message when trying to delete TADIG codes from existing TADIG group ("Status code 405/message undefined")
• Error message when trying to delete complete TADIG group. Same error message as above @Pad-135 https://github.com/Pad-135 Can you replicate this?

Section: General Information

• When selecting start/end dates 2021-01-01 to 2021-12-31, the agreement period is indicated with 11 months. Shouldn't this be 12 months?

Section: Discount Models

• Condition: Unclear what the difference between "Contract Revenue Commitment" & "Deal Revenue Commitment" is @Pad-135 https://github.com/Pad-135 Do you know?
• Entering new discount models for services: The "+" button to select a new service is in the first row of the service. When I want to enter a new service I always have to go up and then down again. The "+" button should therefore be at the end, after entering the rates.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GSMA-CPAS/BWRP-UI/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQD3ZHLH5WSGWJ2PPDMDCLTA57M3ANCNFSM4YIIARQA .

--

CST LTD Bozhidar Ignatov

Software Team Lead

Mladost 4, blok 426A, vh G, et. 2, office G3, Sofia

+359 888 208 418 (Mobil)

E-Mail: ignatov@cst-bg.net

cst-bg.net

[andswk]

Thanks @ignatov17. I think we give the user feedback if there is a problem.

[eliraklosi]

@fhomberg , I loaded your file, with contract name 20210303 - EKlosi TEST V1, through user = "user" from DTlab. After load the TADIG codes for Group 1 on both sides are empty, I picked them manually, still got the error message on Save. I then changed MTC from 0 to 0.1 and it worked.

Looks like there's a bug that does not allow 0 values in flat rate at least. Could have been intended as a feature to make sure rates are filled in but 0 is a legitimate value, so if there's such a check I think it needs to be removed.

@ignatov17 & @hochbergg

[fhomberg]

@eliraklosi ... you are a STAR! I have changed the MTC rate and it works now! But you are right - this needs to be removed ... I have added this issue now to #59

THANK YOU, Federico

[hochbergg]

The "MTC zero rate" has a fix in pull request https://github.com/GSMA-CPAS/BWRP-UI/pull/64

It was not due to validation preventing a zero rate, but rather that while in the UI a default "0" rate was shown, this was not updating the contract being saved (which treated the field as still empty). You can work around this by deleting the "0" and writing "0" again. The fix above will make sure the saved contract uses the default "0" if it hasn't been modified, solving the issue.

[hochbergg]

The request to add an "Add Service" button at the bottom is available in pull request https://github.com/GSMA-CPAS/BWRP-UI/pull/65

[ignatov17]

"Export Draft" is not working in Firefox browser, and is working in Chrome.

Has anyone else noticed a similar compatibility issue?

[hochbergg]

I have just tried "Export Draft" in Firefox on Mac, and it worked successfully. (Firefox version 86.0 64-bit)

[sgerhardt-trilobyte]

If roaming app is loaded inside an Iframe export draft with firefox will not work anymore due to missing CSP Rule (node server)

childSrc: ['\'self\'', 'blob:']

This will be fixed in webapp version v0.4.0