search

GSMA-CPAS / BWRP-UI

Apache License 2.0
1 stars 0 forks source link

MVP Review Back2First calculation #79

Closed eliraklosi closed 3 years ago

eliraklosi commented 3 years ago

Hi,

Contract is 6ca75966a3e3b58ab364813a7004cc476f8d836755c9b0c617a6f3bc58b20578

It has Linear rates everywhere, except Back-to-first for GPRS, where the threshold is: 1,000,000,000 MB for dtstmsp , 3,000,000,000 MB for dtagmsp.

When combined with uploaded usage, threshold should be reached for dtstmsp, but not for dtagmsp. However the calculations show that the second rate (over threshold) was used on both sides for settlement. GPRS Usage is shown correctly, so it's not that.

Could you please check.

thanks, Elira

ldudzinski01 commented 3 years ago

Hi Elira, we'll check this. Thanks a lot for this notice.

sudo-tilakvardhan commented 3 years ago

Fixed the issue to pick up rates from the right threshold. Can be marked close once this pull request closes - https://github.com/GSMA-CPAS/BWRP-calculation-service/pull/14

ldudzinski01 commented 3 years ago

Done