search

GSMA-CPAS / BWRP-chaincode

Apache License 2.0
1 stars 0 forks source link

Cleanup License Header and Contribution Files #44

Closed sschulz-t closed 3 years ago

sschulz-t commented 3 years ago

I added a proper license header to all go files and cleaned up the whole repo and I also moved all "hybrid" related stuff do the hybrid subdirectory. The next step would be to move hybrid/* to / in this repo but this will be a separate PR that we will have to delay until all other open PRS were merged.

The CONTRIB etc. files were moved to docs/* in order to have a clean project dir.

The license information was added via a SPDX header (this is machine readable and easier to parse). I did not put authors and a copyright year into the header as this is unnecessary maintenance work (everybody editing the file would have to add his own name, update the year etc). @RoHech Is that ok with the legal team?

@all: Please check https://github.com/GSMA-CPAS/BWRP-chaincode/blob/ssch-cleanup_license/docs/CONTRIBUTING.md and https://github.com/GSMA-CPAS/BWRP-chaincode/blob/ssch-cleanup_license/docs/CODEOWNERS Please verify that your information/name was added properly (especially the company name!). If not: please add the correct data as a review in this PR.

RoHech commented 3 years ago

Thank you Simon for the suggestion and update. I have two comments: 1) When prioritizing machine readability I'd rather suggest making the repository REUSE compliant. I'll check for further small changes that would be required - and I'll share the proposal with the legal group. Would this be OK with you? 2) considering my neglectable input please do remove #RoHech from the NOTICE file.

sschulz-t commented 3 years ago

Thank you Simon for the suggestion and update. I have two comments:

  1. When prioritizing machine readability I'd rather suggest making the repository REUSE compliant. I'll check for further small changes that would be required - and I'll share the proposal with the legal group. Would this be OK with you?

That sounds good to me. I will do the modifications and add it to this pr.

sschulz-t commented 3 years ago

ok. i just did the changes to make it "REUSE" compliant, see https://github.com/GSMA-CPAS/BWRP-chaincode/pull/44/commits/222b022f061c6c81749223d62cb6ecafed3e0ec2