search

GSMA-CPAS / BWRP-chaincode

Apache License 2.0
1 stars 0 forks source link

add support to run chaincode as external service #55

Closed sschulz-t closed 2 years ago

sschulz-t commented 3 years ago

this pr allows to run the chaincode as external service

do not merge yet

sschulz-t commented 3 years ago

the previous commit just repaired the broken state of the branch caused by the force-push

sschulz-t commented 2 years ago

yes, merging #60 before is necessary to update to autogenerated certs during testing. merging 60 and then reviewing this one sounds like a good plan :)

informartin commented 2 years ago

The dev-setup failed as offchain.go attempted to read the TLS files before checking if the chaincode is executed externally. I have moved the respective lines behind the check.

As the PR passes all tests, including the dev-setup, it can be merged from my point of view.

sschulz-t commented 2 years ago

good find martin! thanks a lot!