search

GSMA-CPAS / BWRP-chaincode

Apache License 2.0
1 stars 0 forks source link

Marshalling error is caught w/o marshalling operation #9

Closed informartin closed 3 years ago

informartin commented 3 years ago

It seems to me the StorePrivateDocument() function is performing an error check on a marshalling operation that is never executed? Is it a leftover of a former marshalling operation that was omitted or am I overlooking anything?

https://github.com/GSMA-CPAS/BWRP-chaincode/blob/672002c8ea228efe2c3609a20cf229b5a1a6e255/hybrid/offchain.go#L406-L417

sschulz-t commented 3 years ago

Good find! The error check is indeed no longer needed and can be removed.