search

GSMA-CPAS / BWRP-common-adapter

The "Layer 2.5" with all Common functionality APIs
Apache License 2.0
2 stars 0 forks source link

Rename "documentId" to "referenceId" #15

Closed zkong-gsma closed 3 years ago

zkong-gsma commented 3 years ago

This Task Comes in 2 part.

Part 1, Northbound API of common-adapter. All returning response from common-adapter will reflect from documentId->referenceId.

Part 2. Southbound API. Since we are going to change all the reference, eventually when blockchain-adapter gets updated, we will also need to update the southbound consuming part of the renaming.

sschulz-t commented 3 years ago

The progress of the blockchain adapter and chaincode changes will be tracked here: https://github.com/GSMA-CPAS/BWRP-blockchain-adapter/issues/16 https://github.com/GSMA-CPAS/BWRP-chaincode/issues/26 I will let you know once those tickets are finished.

gyej7354 commented 3 years ago

ready to merge this from dev branch to master

zkong-gsma commented 3 years ago

Northbound is now complete.

will require a second part once blockchain-adapter is also ready.

sschulz-t commented 3 years ago

changes for blockchain adapter and chaincode are done and will be merged to master once tests in the development setup are passed. see

smeyerzu commented 3 years ago

I tested and merged chaincode and blockchain-adapter in the dev setup. Please continue with your southbound-API. Add changes to this PR: https://github.com/GSMA-CPAS/BWRP-development-setup/pull/15

zkong-gsma commented 3 years ago

This is now completed.