search

GSMA-CPAS / BWRP-common-adapter

The "Layer 2.5" with all Common functionality APIs
Apache License 2.0
2 stars 0 forks source link

Environment variable prefix #19

Closed sschulz-t closed 3 years ago

sschulz-t commented 3 years ago

I would propose to use a name prefix for all common adapter env vars like COMMONADAPTER for all common adapter related stuff. E.g. instead of using DB_POOL_SIZE I would suggest to use COMMON_ADAPTER_DB_POOL_SIZE.

This has two reasons. Firstly, it is much easier to identify what those variables are good for when browsing the BWRP config files. And secondly, we might face some name collisions in the future.

What do you think?

zkong-gsma commented 3 years ago

i can see your concerns. especially under the "development-setup" environment.

I can start renaming those environment variable as suggested up to the "Docker"/"Kube deployment" files to start with.

and will finally rename /server/config.js once sync with the Orange Teams.

Is that OK?

sschulz-t commented 3 years ago

sounds very good 👍

csarthou commented 3 years ago

Pull request created : #22