search

GSMA-CPAS / BWRP-common-adapter

The "Layer 2.5" with all Common functionality APIs
Apache License 2.0
2 stars 0 forks source link

Blockchain ref integration #37

Closed zkong-gsma closed 3 years ago

zkong-gsma commented 3 years ago

Modify to work with the new changes from Blockchain-Adapter commit 29c85d6

tested using setup on "local development setup" branch "common-adapter-update-test"

zkong-gsma commented 3 years ago

For me, this branch merge request will create a lot of commits "update" in dev branch history. We are trying to define what is done on each commit, and all this commits should be merged in one uniq commit before getting them in dev branch.

And a second point: we can't update dev branch with 'npm run test' script in failure. It's our reference of "what must be done", and "what must not regress".

I don't disagree with that. This "Pull Request" do not need to be "mergerd", you can see the "file" changes and make a New "clone" from dev, and put all "upadates" in One.

more importantly is discussing the "changes" and i have tested them in this.