GSMA-CPAS / BWRP-common-adapter

The "Layer 2.5" with all Common functionality APIs
Apache License 2.0
2 stars 0 forks source link

Unify the RAW-object (southbound) and client-object (northbound) #41

Open smeyerzu opened 3 years ago

smeyerzu commented 3 years ago

I propose that the common-adapter unifies the objects/data-structures which are exchanged north- and southbound. In my opinion it is crucial for the project that at least the body and header of a northbound object match the southbound payload (raw-object).

Minor differences like white-space and line-break removal could be ok as long as the data matches and stays externally verifiable and results are reproducible. Everything else leads to inconsistencies on the client-side and need to be prevented.

Right now differences include: contractReferenceID, fromMSP, toMSP, signatures

Please do not discuss individual fields in this issue but discuss the general idea of removing differences between "north" and "south".

sschulz-t commented 3 years ago

As proposed in the meeting another option could be to drop the duplication of the raw data and keep only the raw data and decode it on the fly where needed. This way there can be no difference (e.g. caused by a api change, bug, or an attacker).