GSS-Cogs / databaker

Command line tool to convert spreadsheets to databases, made for the UK's Office for National Statistics.
Other
1 stars 0 forks source link

Issue 18/within range handler #24

Closed mikeAdamss closed 3 years ago

mikeAdamss commented 3 years ago

Start of the WITHIN lookup engine. Draft PR with a few things still to do.

Things to do:

CharlesRendle commented 3 years ago

Ready for review.

All scenarios completed with accompanying tests. Have left the lookup functions in their verbose forms with the aim that this can be improved upon.

Please look into the within engine functions for searching up and down columns as I am not entirely happy with my logic behind them. Also, I imagine there needs to be a wider breadth for the exception test scenarios. Any comments there would be great.