DEFRA-Carbon-Footprint-GHG-direct - Githubissues

GSS-Cogs / family-climate-change

1 stars 1 forks source link

DEFRA-Carbon-Footprint-GHG-direct #98

Open Shannon95 opened 2 years ago

Shannon95 commented 2 years ago

[x] Transform specified
[x] Transform implemented
[x] Codelists created
[x] Column mapping
[x] Additional metadata
[ ] Reviewed
[ ] Periodic build trigger

ajtucker commented 1 year ago

I was just looking at this on https://beta.gss-data.org.uk/cube/explore?uri=http%3A%2F%2Fgss-data.org.uk%2Fdata%2Fgss_data%2Fclimate-change%2Fdefra-carbon-footprint-ghg-direct-catalog-entry and noticed that there are what look like URIs in the SIC Section column.

If you squint, you can see that the domain name is separated by hyphens (-) and not dots (.).

I think the offending lines are here: https://github.com/GSS-Cogs/family-climate-change/blob/master/datasets/DEFRA-Carbon-Footprint-GHG-direct/main.py#L22-L23