GSS-Cogs / family-trade

1 stars 2 forks source link

ONS_CPA #18

Open ajtucker opened 4 years ago

Shannon95 commented 4 years ago
MartynBSpooner commented 4 years ago

Outstanding: Product dimension (agreed meeting to discuss).

ajtucker commented 4 years ago

Added new dimension, <http://gss-data.org.uk/def/dimension/cpa>, using codelist <http://stamina-project.org/codes/cpav2008/cpa>, separately labelling it "Product". Commit 11d9711efa8a43987d7b9bc7fe3e5c2c0dce803f

See Swirrl/ons-data-export#23

JasonHowell commented 4 years ago

BA's have reviewed and good to go.

JasonHowell commented 4 years ago

Closing issue as now been deployed onto PMDv4.

Shannon95 commented 3 years ago

GitHub https://github.com/GSS-Cogs/family-trade/tree/master/datasets/ONS_CPA Jenkins https://ci.floop.org.uk/job/GSS_data/job/Trade/job/ONS_CPA/

canwaf commented 3 years ago

The xlsx is no longer properly formed as it has too many columns. Will use the CSV instead.

LPerryman commented 3 years ago

published to PMD4 with CDIDS but need to check unit with BAs, have out in gbp million as temp measure

https://staging.gss-data.org.uk/cube/explore?uri=http%3A%2F%2Fgss-data.org.uk%2Fdata%2Fgss_data%2Ftrade%2Fons_cpa-catalog-entry

Tracey-B commented 3 years ago

BA Comments; Producer confirmed unit as GBP Million. There is no Tech Spec.
I have completed a QA check on the transformed dataset in PMD4 and had discussions with @LPerryman. As far as i can determine the dataset appears reasonable however I am unable to complete a full QA check as I am unable to sort or filter any of the dimensions. @rossbowen @JasonHowell please see comments above.

mikeAdamss commented 3 years ago

sorry to be be awkward but there's a bug on this scraper at the mo, should be fixed and in by some point relatively soon (I'll update this comment when it's sorted). Probably no point picking this up before if you need to rerun it, it'll just fall over. https://github.com/GSS-Cogs/gss-utils/issues/188. Back to working 😄

mikeAdamss commented 3 years ago

this had an erroneous failure on the 25th, that was the same week we deployed all the databaker/gss-utils fixes. It works now, just needed to kick the job off again.

it's probably worth rerunning on Jenkins for any fail that are more than about a week old, might be they work now.

Shannon95 commented 3 years ago

Published on PMD4 with filters working: https://staging.gss-data.org.uk/cube/explore?uri=http%3A%2F%2Fgss-data.org.uk%2Fdata%2Fgss_data%2Ftrade%2Fons_cpa-catalog-entry&filters-drawer=open

Shannon95 commented 3 years ago

Now passing again on Jenkins - avilable on staging here https://staging.gss-data.org.uk/cube/explore?uri=http%3A%2F%2Fgss-data.org.uk%2Fdata%2Fgss_data%2Ftrade%2Fons_cpa-catalog-entry

Robsteranium commented 3 years ago

The CPA dimension ought to be a sub-property of the family's product dimension.

JasonHowell commented 2 years ago

@rossbowen Please see above feedback from Robin. What are the next steps?

The dataset is published on Beta env.