search

GSSoC24 / .github

GSSoC is a 3-month long #OpenSource program by GirlScript Foundation, India.
4 stars 3 forks source link

Task 3: Certificate Checks: Priority #15

Closed sanjay-kv closed 2 months ago

sanjay-kv commented 2 months ago

We will be rolling out the certificate from today, which means we have to make sure everything works properly before rolling it out.

So, we need to check and report any issues with this comment. Dont share details to outside this group.

Certificate link: https://gssoc.girlscript.tech/verify_cert

Github resource: https://github.com/girlscript/gssoc-website-new/tree/main/public/certificates/2024 repo link: https://github.com/girlscript/gssoc-website-new

sanjay-kv commented 2 months ago

Ex: This is report made by @ mastan

image Hi, I noticed that for the top 100 contributors, the certification template shows "Certificate of Participation" instead of "Certificate of Appreciation." This might create confusion among contributors and they may get disappointed.

sanjay-kv commented 2 months ago

Issue mentioned by @ nishatn image

mobile download fail:

Solution: the problem is current code is building one frame in big screen where there is certificate image in background and over that image there is text . which previous contributor has aligned manually so when we click on download so that frame is getting download as it is . which he have handled upto screen width of 1080px .after that the text and image is not handled . +the frame display gets none after 1080px screen so thats why when we try to download certificate its give 0B image (coruptt image) because frame doesnt exist in that device .

Swarnendu0123 commented 2 months ago
image
  1. The certificate itself looks like this. We have to replace the image, with the title Certificate of Appreciation. That’s it. The file location is: 
    public/certificates/2024/GSSoC_TopContrib_Cert.png
  2. Also, the image quality of the certificate is decreased. We can replace all the certificates with new high-quality certificates.
  3. Every certificate should include a unique id, for verification.
vansh-codes commented 2 months ago
RadhikaMalpani1702 commented 2 months ago

Hi @sanjay-kv ,

I’m unable to download my certificate even though I’ve entered my correct details. It shows a verification failed error. My rank is 29th.

This is my email ID: radhikavishnudas2002@gmail.com

Please check on this issue. It seems to be affecting several contributors, especially those who didn’t receive a confirmation email for GSSoC or those who are on the leaderboard due to the Postman challenge.

https://github.com/user-attachments/assets/328c1eeb-8d6e-429f-9c25-f0decca8c881

MastanSayyad commented 2 months ago

Hi @sanjay-kv,

The issue found by @RadhikaMalpani1702 is significant. I was sure this might happen. I think We need to add these people's email IDs to the certificate data rendering so they can verify and download their certificates.

The affected groups are:

vansh-codes commented 2 months ago

Hi @sanjay-kv ,

I’m unable to download my certificate even though I’ve entered my correct details. It shows a verification failed error. My rank is 29th.

This is my email ID: radhikavishnudas2002@gmail.com

Please check on this issue. It seems to be affecting several contributors, especially those who didn’t receive a confirmation email for GSSoC or those who are on the leaderboard due to the Postman challenge.

15.08.2024_07.52.43_REC.mp4

Hii @RadhikaMalpani1702 , Your verification is failing because your mail id is not mentioned here: https://github.com/girlscript/gssoc-website-new/blob/main/public/certificatesData/2024/Top100.json

@sanjay-kv I think some data is wrong in Top100.json file as I can see the emails are mentioned according to rank, but it gets wrong at few places disturbing other datas position as well. For example: Siddheya's rank is 3rd but he is listed 4th in the json file and many more places where the contributors are mentioned in wrong position and only 94 emails are mentioned, 6 are missing. One of those missing email is of @RadhikaMalpani1702 Please recheck the Top100.json and mention the contributors missed out.

RadhikaMalpani1702 commented 2 months ago

That's great insight, @vansh-codes Similarly, the Postman API Challenge participants on the leaderboard might face the same issue.

MastanSayyad commented 2 months ago

Yes, @vansh-codes, instead of Sidhheya, Unnimaya is listed. While this might not have a significant impact, the missing emails could definitely cause issues.

vansh-codes commented 2 months ago

@MastanSayyad exactly! Also because of wrong ordering now it becomes tough to find those 6 people whose email is not mentioned. It could have been easier if the order was the same as the rank on the leaderboard

sanjay-kv commented 2 months ago

@vansh-codes we are creating a new template, I noticed certificate quality is not good. https://www.figma.com/design/wlIszNShK2h7rwPpzjuVYq/Certification?node-id=411-3&t=8Zm52qGd91VWxoJq-0

sanjay-kv commented 2 months ago

Hi @sanjay-kv , I’m unable to download my certificate even though I’ve entered my correct details. It shows a verification failed error. My rank is 29th. This is my email ID: radhikavishnudas2002@gmail.com Please check on this issue. It seems to be affecting several contributors, especially those who didn’t receive a confirmation email for GSSoC or those who are on the leaderboard due to the Postman challenge. 15.08.2024_07.52.43_REC.mp4

Hii @RadhikaMalpani1702 , Your verification is failing because your mail id is not mentioned here: https://github.com/girlscript/gssoc-website-new/blob/main/public/certificatesData/2024/Top100.json

@sanjay-kv I think some data is wrong in Top100.json file as I can see the emails are mentioned according to rank, but it gets wrong at few places disturbing other datas position as well. For example: Siddheya's rank is 3rd but he is listed 4th in the json file and many more places where the contributors are mentioned in wrong position and only 94 emails are mentioned, 6 are missing. One of those missing email is of @RadhikaMalpani1702 Please recheck the Top100.json and mention the contributors missed out.

noted.

sanjay-kv commented 2 months ago

@MastanSayyad exactly! Also because of wrong ordering now it becomes tough to find those 6 people whose email is not mentioned. It could have been easier if the order was the same as the rank on the leaderboard

@Hemu21 can you look into this.

vansh-codes commented 2 months ago

@sanjay-kv this template looks good and attractive 💥🚀

Hemu21 commented 2 months ago

You can see the list of missing mails contributors github usernames. https://github.com/GSSoC24/Contributor/discussions/591

Hemu21 commented 2 months ago

@RadhikaMalpani1702 now you can download your certificate.

RadhikaMalpani1702 commented 2 months ago

Yeah thank @Hemu21

aslams2020 commented 2 months ago

Hey @sanjay-kv

The input box for entries for certificates Enter registered email , Enter name is not visible in light mode

As you can see here - image

User's may tend to get confused where to enter my inputs, I myself got confused earlier..

sanjay-kv commented 2 months ago

Hey @sanjay-kv

The input box for entries for certificates Enter registered email , Enter name is not visible in light mode

As you can see here - image

User's may tend to get confused where to enter my inputs, I myself got confused earlier..

thanks for highlighting.

aslams2020 commented 2 months ago

@sanjay-kv To emphasize the importance of the "CEO Name" and "Managing Director Name," we can style these elements in black with bold text. Additionally, we can use a grey color for their respective titles "to distinguish their roles" in the GirlScript Foundation.

Currently :
image

aditya-bhaumik commented 2 months ago

image

@sanjay-kv in dark mode when we go to select a field there is no line visible that the field has been selected it can cause some confusion for some people especially the ones who are a bit in hurry

Even i got confused

only after typing i noticed that the field has been selected in the above image i have selected the email field but as you can see we cant tell if the field has been selected as the white line is right on top of the left side

vansh-codes commented 2 months ago

image

@sanjay-kv in dark mode when we go to select a field there is no line visible that the field has been selected it can cause some confusion for some people especially the ones who are a bit in hurry

Even i got confused

only after typing i noticed that the field has been selected in the above image i have selected the email field but as you can see we cant tell if the field has been selected as the white line is right on top of the left side

Hey @aditya-bhaumik It's similar to the one told in this https://github.com/GSSoC24/.github/issues/15#issuecomment-2290580953

aditya-bhaumik commented 2 months ago

@vansh-codes thats for light mode i checked that comment and wrote here this is for dark mode even the dark mode is facing the same problem If i had not added here they might have only fixed it for light mode but the problem is also there in dark mode so to make their work easier i mentioned it here and dont worry its not a competition if it was same also i dont think there should be a issue

vansh-codes commented 2 months ago

@aditya-bhaumik agreed 💯

vansh-codes commented 2 months ago

Idea for certificate verification: https://github.com/GSSoC24/.github/discussions/29

aditya-bhaumik commented 2 months ago

i think for the certificate verification both mine and vansh's name should be added as he improved the idea which i had given in #27

MastanSayyad commented 2 months ago

@aditya-bhaumik It will get added, you can ignore the above list it was just a summary for past suggestions

sanjay-kv commented 2 months ago

https://drive.google.com/drive/folders/1NhZpRgjQbbP3S_dcWsaGCn43GkCtAGAw?usp=sharing and do the PR @MastanSayyad if anyone free can you replace the existing certificates with these? https://github.com/girlscript/gssoc-website-new/tree/main/public/certificates/2024 https://github.com/girlscript/gssoc-website-new/commits/main/

MastanSayyad commented 2 months ago

Sure @sanjay-kv

shreyash3087 commented 2 months ago

Issue mentioned by @ nishatn image

mobile download fail:

Solution: the problem is current code is building one frame in big screen where there is certificate image in background and over that image there is text . which previous contributor has aligned manually so when we click on download so that frame is getting download as it is . which he have handled upto screen width of 1080px .after that the text and image is not handled . +the frame display gets none after 1080px screen so thats why when we try to download certificate its give 0B image (coruptt image) because frame doesnt exist in that device .

i have a solution to this @sanjay-kv ,what we can do is for mobile devices we can make the whole certificate div as absolute and put it out of the screen using top:10000px or a very high value or something,instead of making the frame none,this will allow us to get the certificate even in mobile devices,since the frame is not none but just out of the screen. check out this video -

https://github.com/user-attachments/assets/523b87fc-26e6-45e5-b7eb-31d17e8cd216

vansh-codes commented 2 months ago

https://drive.google.com/drive/folders/1NhZpRgjQbbP3S_dcWsaGCn43GkCtAGAw?usp=sharing and do the PR @MastanSayyad if anyone free can you replace the existing certificates with these? https://github.com/girlscript/gssoc-website-new/tree/main/public/certificates/2024 https://github.com/girlscript/gssoc-website-new/commits/main/

Hi @sanjay-kv

https://drive.google.com/file/d/1nNgMMsQhSuay9vrsMstNHnN0IUnWBsfA/view?usp=drivesdk In this .xyz and girlscript.tech is not mentioned in the presented section, please have a look if it's a mistake or been done knowingly.. IMG_20240815_145022.png

aslams2020 commented 2 months ago

Hey @sanjay-kv after the new update of certificates

for Both Contributors and TOP100 , There is "Certificate of Appreciation" image

However - For Contributors - It Should be "Certificate of Participation" and For Top100 Contributors - It Should be "Certificate of Appreaciation" Which makes those top-performers certificate unique.

vansh-codes commented 2 months ago

@sanjay-kv

Vansh Chaurasiya_Cert_Top Contributor_GSSoC2024 (1)

image

The position of name and the placeholder XXXXXXX is wrong

aditya-bhaumik commented 2 months ago

@aslams2020 yes exactly as the only thing extra for 61 to 100 was the certificate of appreciation now if everyone is getting that then there is nothing unique before it was mentioned that people who score 60 points will get certificate of participation so many people made only that much score

MastanSayyad commented 2 months ago

@vansh-codes Yeah, They are fixing it

Ojas-Arora commented 2 months ago

@sanjay-kv Sir for every certificate Certificate Id should be present which would be different for different contributors/mentors/project admin. Right now after generating certificate no Certificate Id is generated.

sanjay-kv commented 2 months ago

✅changes done : https://github.com/GSSoC24/.github/issues/35

sanjay-kv commented 2 months ago

Hey @sanjay-kv

The input box for entries for certificates Enter registered email , Enter name is not visible in light mode

As you can see here - image

User's may tend to get confused where to enter my inputs, I myself got confused earlier..

This is fixed ✅✅

sanjay-kv commented 2 months ago

i think for the certificate verification both mine and vansh's name should be added as he improved the idea which i had given in #27

sure

shreyash3087 commented 2 months ago

Issue mentioned by @ nishatn image mobile download fail: Solution: the problem is current code is building one frame in big screen where there is certificate image in background and over that image there is text . which previous contributor has aligned manually so when we click on download so that frame is getting download as it is . which he have handled upto screen width of 1080px .after that the text and image is not handled . +the frame display gets none after 1080px screen so thats why when we try to download certificate its give 0B image (coruptt image) because frame doesnt exist in that device .

i have a solution to this @sanjay-kv ,what we can do is for mobile devices we can make the whole certificate div as absolute and put it out of the screen using top:10000px or a very high value or something,instead of making the frame none,this will allow us to get the certificate even in mobile devices,since the frame is not none but just out of the screen. check out this video -

loom-video.6.mp4

@sanjay-kv check this out for #35

sanjay-kv commented 2 months ago

https://drive.google.com/drive/folders/1NhZpRgjQbbP3S_dcWsaGCn43GkCtAGAw?usp=sharing and do the PR @MastanSayyad if anyone free can you replace the existing certificates with these? https://github.com/girlscript/gssoc-website-new/tree/main/public/certificates/2024 https://github.com/girlscript/gssoc-website-new/commits/main/

Hi @sanjay-kv

https://drive.google.com/file/d/1nNgMMsQhSuay9vrsMstNHnN0IUnWBsfA/view?usp=drivesdk In this .xyz and girlscript.tech is not mentioned in the presented section, please have a look if it's a mistake or been done knowingly.. IMG_20240815_145022.png

https://github.com/GSSoC24/.github/issues/38

raised issue for this