GSTJ / react-native-code-push-plugin

Code Push plugin to integrate seamlessly with Expo
15 stars 4 forks source link

[README] Update README - install #2

Closed mvolonnino closed 10 months ago

mvolonnino commented 10 months ago

This is not really an issue but just wanted to make it aware in case anyone else i having the same issues I faced, or if they are migrating from utilizing eas-updates to codepush

Make sure to completely remove the expo-updates package from package.json if you utilized that before integrating this codepush plugin There will be no warnings or anything like that and everything will seem to work as intended.

I was running into two specific issues:


After completely remove the expo-updates with

yarn remove expo-updates

and removing the below code from the app.json, then this plugin worked correctly and I have no issues on iOS or android this had to deal with hooking up eas updates and completely removing that along with removing package seems to have work

// filename: app.json

{
  "expo": {
       //...
       updates: {}, // remove this
}

Huge shoutout to @GSTJ for creating this plugin and to @mgscreativa for helping debug as well and finding the solution to those issues I was running into above.

mgscreativa commented 10 months ago

Hi @GSTJ, just created a PR to update the readme

GSTJ commented 10 months ago

Updated, thanks guys! Good find there.