GSTJ / react-native-magic-modal

πŸ¦„ A modal library that can be called imperatively from anywhere!
https://github.com/GSTJ/react-native-magic-modal
MIT License
186 stars 8 forks source link

Add portal defaultProps #13

Closed laogui closed 1 year ago

laogui commented 1 year ago

Note: erase all explanatory text from this template, replacing it with your words/images.

πŸ“ DESCRIPTION:

Briefly explain the solution (this will make it easier for the reviewer to confirm that the code does what it should), for example:

πŸ–Ό picture: PRINTS & GIFS:

Include the best screenshots or gifs of the feature if applicable.

(on Macs, ⌘ + ⇧ + 5 is your friend as you can take multiple screenshots/recordings from a fixed window)

πŸ’› MY AMAZING PR CONTAINS:

Does this PR change only one thing (And only what is necessary for it)?
Awesome tests or e2e (avoid shallow rendering)
github-actions[bot] commented 1 year ago

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟒 Statements 100% 35/35
🟒 Branches 100% 5/5
🟒 Functions 92.31% 12/13
🟒 Lines 100% 69/69

Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Report generated by πŸ§ͺjest coverage report action from 3ef8a77c0d3f35a1ab53abec0bfdaf2d5866d23a

GSTJ commented 1 year ago

Hey, Iaogui! There's no need to pass any props to the MagicModal. We are already extending the styles with the props passed on the magicModal.show method. That leaves enough flexibility to style individual modals any way you prefer.